Review main Merged

67622[TASK] Use d3 v6 microlibraries

Benjamin Franzke CR +2 V +2 Hard +94 −286 updated 02/02/21, 13:20

Commit message

In order to avoid loading an unnecessarily large complete d3 bundle,
we now only pull in the small amount of modules we actually need.

d3.transition() is replaced by the native web animation api, as
d3-transition would pull in 4 more libraries
(d3-color, d3-ease, d3-interpolate and d3-timer).
d3-dispatch could easily be replaced by native CustomEvents, but
it is a dependency of d3-drag and therefore shipped right now.

This change reduces load size from 262K to 19K.

yarn remove d3
yarn add d3-dispatch d3-drag d3-selection
grunt build

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Richard Haeser +1
    • Oliver Hader +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 811

  1. Benjamin Franzke uploaded patch set 1 02/01/21, 20:23

  2. Benjamin Franzke uploaded patch set 2 02/01/21, 20:25

  3. TYPO3com voted on patch set 1 V -1 02/01/21, 20:41 Completed build in 10m 21s on Mon, 1 Feb, 08:41 PM Test Summary: 80 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9175

  4. TYPO3com voted on patch set 2 V -1 02/01/21, 20:45 Completed build in 15m 08s on Mon, 1 Feb, 08:45 PM Test Summary: 9 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9176

  5. Benjamin Franzke uploaded patch set 3 02/01/21, 21:28

  6. TYPO3com voted on patch set 3 V +1 02/01/21, 21:58 Completed build in 21m 23s on Mon, 1 Feb, 09:58 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9182

  7. Andreas Kienast voted on patch set 3 CR +1 02/02/21, 06:56

  8. Richard Haeser voted on patch set 3 V +1 CR +1 02/02/21, 08:27

  9. Benni Mack voted on patch set 3 V +2 CR +2 02/02/21, 10:42

  10. Benni Mack merged patch set 4 02/02/21, 10:42

  11. Oliver Hader voted on patch set 4 V +1 02/02/21, 13:20