Review main Merged

67627[BUGFIX] Restore styling of localization wizard

Richard Haeser CR +2 V +2 Easy +11 −4 updated 02/06/21, 21:21

Commit message

Updated styling and javascript to restore styling of the
localization wizard after the update to bootstrap 5.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Riccardo De Contardi +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 5

Review log 813

  1. Richard Haeser uploaded patch set 1 02/02/21, 09:36

  2. TYPO3com voted on patch set 1 V +1 02/02/21, 09:47 Completed build in 09m 51s on Tue, 2 Feb, 09:47 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9189

  3. Richard Haeser commented on patch set 1 02/02/21, 09:57

    Localization.ts:310

    data-bs-toggle="button" doesn't do the trick as it is would give the possibility to have two active buttons.
  4. Richard Haeser commented on patch set 1 02/02/21, 11:17

    Localization.ts:310 Reply

    Ack
  5. Richard Haeser uploaded patch set 2 02/02/21, 13:47

  6. TYPO3com voted on patch set 2 V -1 02/02/21, 13:58 Completed build in 09m 29s on Tue, 2 Feb, 01:58 PM Test Summary: 31491 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9194

  7. TYPO3com commented on patch set 2 02/02/21, 14:08 Completed build in 09m 17s on Tue, 2 Feb, 02:08 PM Test Summary: 31133 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9195

  8. TYPO3com commented on patch set 2 02/02/21, 14:18 Completed build in 08m 57s on Tue, 2 Feb, 02:18 PM Test Summary: 31693 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9197

  9. TYPO3com voted on patch set 2 V +1 02/03/21, 15:01 Completed build in 10m 39s on Wed, 3 Feb, 03:01 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9215

  10. Riccardo De Contardi commented on patch set 2 V +1 02/06/21, 15:24

    with the patch the progress bar occupies the correct space
  11. Andreas Kienast voted on patch set 2 V +1 CR +1 02/06/21, 15:58

  12. Benni Mack voted on patch set 2 V +2 CR +2 02/06/21, 21:21

  13. Benni Mack merged patch set 3 02/06/21, 21:21