Review main Merged

67628[BUGFIX] Fix frameset module property for FileList

Oli Bartsch CR +2 V +2 Easy +11 −4 updated 02/06/21, 21:43

Commit message

BackendController::generateJavascript() creates the
top.fsMod object to provide frameset modules an easy
way of storing their state. The FileList module e.g.
stores the current folder identifier. Therefore, after
switching back to the FileList module, the previously
selected folder is used.

This behaviour is now restored by replacing the
"instanceof" check, which always evaluated to FALSE,
with a typeof check. It's furthermore now ensured
that the id will always be set, even if recentIds
is not yet an object.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 914

  1. Oli Bartsch uploaded patch set 1 02/02/21, 13:59

  2. TYPO3com voted on patch set 1 V -1 02/02/21, 14:11 Completed build in 10m 35s on Tue, 2 Feb, 02:11 PM Test Summary: 27933 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9196

  3. Oliver Hader commented on patch set 1 CR -1 02/02/21, 14:13

    FileList.ts:40

    "Uncaught TypeError: Cannot set property 'file' of undefined" in case `top.fsMod.recentIds` is not an object...
  4. TYPO3com commented on patch set 1 02/02/21, 14:17 Completed build in 27m 42s on Tue, 2 Feb, 02:17 PM Test Summary: 28999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9196

  5. Oli Bartsch commented on patch set 1 02/02/21, 14:47

    FileList.ts:40 Reply

    Hmm, how did you encounter this, since it should always be set by BackendController::generateJavascript().
  6. Oli Bartsch uploaded patch set 2 02/02/21, 15:09

  7. Oli Bartsch commented on patch set 2 02/02/21, 15:11

    FileList.ts:40 Reply Unresolved

    I added a typeof check to prevent possible type errors. The new patches now also sets the id, even if recentIds is not yet an object.
  8. TYPO3com voted on patch set 2 V -1 02/02/21, 15:18 Completed build in 08m 29s on Tue, 2 Feb, 03:18 PM Test Summary: 31345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9200

  9. Benni Mack updated the commit message in patch set 3 02/02/21, 20:40

  10. TYPO3com voted on patch set 3 V -1 02/02/21, 20:51 Completed build in 10m 17s on Tue, 2 Feb, 08:51 PM Test Summary: 25713 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9204

  11. TYPO3com voted on patch set 3 V +1 02/03/21, 16:00 Completed build in 19h 30m 15s on Wed, 3 Feb, 04:00 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9204

  12. Benni Mack voted on patch set 3 V +1 CR +1 02/06/21, 21:41

  13. Andreas Kienast voted on patch set 3 V +2 CR +2 02/06/21, 21:43

  14. Andreas Kienast merged patch set 4 02/06/21, 21:43