67628[BUGFIX] Fix frameset module property for FileList
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benni Mack +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 914
-
Oli Bartsch uploaded patch set 1 02/02/21, 13:59
-
TYPO3com voted on patch set 1 V -1 02/02/21, 14:11 Completed build in 10m 35s on Tue, 2 Feb, 02:11 PM Test Summary: 27933 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9196
-
Oliver Hader commented on patch set 1 CR -1 02/02/21, 14:13
-
TYPO3com commented on patch set 1 02/02/21, 14:17 Completed build in 27m 42s on Tue, 2 Feb, 02:17 PM Test Summary: 28999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9196
-
Oli Bartsch commented on patch set 1 02/02/21, 14:47
FileList.ts:40ReplyHmm, how did you encounter this, since it should always be set by BackendController::generateJavascript(). -
Oli Bartsch uploaded patch set 2 02/02/21, 15:09
-
Oli Bartsch commented on patch set 2 02/02/21, 15:11
FileList.ts:40Reply UnresolvedI added a typeof check to prevent possible type errors. The new patches now also sets the id, even if recentIds is not yet an object. -
TYPO3com voted on patch set 2 V -1 02/02/21, 15:18 Completed build in 08m 29s on Tue, 2 Feb, 03:18 PM Test Summary: 31345 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9200
-
Benni Mack updated the commit message in patch set 3 02/02/21, 20:40
-
TYPO3com voted on patch set 3 V -1 02/02/21, 20:51 Completed build in 10m 17s on Tue, 2 Feb, 08:51 PM Test Summary: 25713 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9204
-
TYPO3com voted on patch set 3 V +1 02/03/21, 16:00 Completed build in 19h 30m 15s on Wed, 3 Feb, 04:00 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9204
-
Benni Mack voted on patch set 3 V +1 CR +1 02/06/21, 21:41
-
Andreas Kienast voted on patch set 3 V +2 CR +2 02/06/21, 21:43
-
Andreas Kienast merged patch set 4 02/06/21, 21:43
FileList.ts:40