Review main Merged

67630[BUGFIX] Do not render empty type attribute

Oli Bartsch CR +2 V +2 Easy +2 −1 updated 02/03/21, 16:16

Commit message

PageRenderer now omits empty type attributes
also for scripts added through includeJSLibs
or includeJSFooterlibs.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 58

  1. Oli Bartsch uploaded patch set 1 02/02/21, 14:44

  2. Oli Bartsch updated the commit message in patch set 2 02/02/21, 14:45

  3. TYPO3com voted on patch set 1 V -1 02/02/21, 14:53 Completed build in 08m 20s on Tue, 2 Feb, 02:53 PM Test Summary: 31487 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9198

  4. TYPO3com voted on patch set 2 V -1 02/02/21, 14:55 Completed build in 09m 49s on Tue, 2 Feb, 02:55 PM Test Summary: 28234 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9199

  5. Georg Ringer voted on patch set 2 V +1 CR +1 02/03/21, 10:51

  6. TYPO3com voted on patch set 2 V +1 02/03/21, 15:59 Completed build in 1h 22m 48s on Wed, 3 Feb, 03:59 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9199

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/03/21, 16:16

  8. Benni Mack merged patch set 3 02/03/21, 16:16