Review main Merged

67631[BUGFIX] Respect auth mode in page module again

Oli Bartsch CR +2 V +2 Easy +5 −5 updated 02/10/21, 09:58

Commit message

If a non-admin does not have permissions to access
a specific CType, disallowed via AD mode, the header
icons, e.g. edit or delete, are now not longer displayed
in the page module (fluid based) to prevent error
messages in FormEngine.

Therefore, recordEditAccessInternals is used, which
was also the case in PageLayoutView and furthermore
already includes the language access check.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Riccardo De Contardi +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Oli Bartsch uploaded patch set 1 02/02/21, 19:08

  2. TYPO3com voted on patch set 1 V -1 02/02/21, 19:17 Completed build in 08m 06s on Tue, 2 Feb, 07:17 PM Test Summary: 25954 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9202

  3. TYPO3com voted on patch set 1 V +1 02/03/21, 16:01 Completed build in 21h 00m 27s on Wed, 3 Feb, 04:01 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9202

  4. Riccardo De Contardi commented on patch set 1 V +1 02/06/21, 15:18

    Verified with page module and master with the following procedure: 1) Create a page which is accessible to an "editor" user / "editors" group /give full privileges in Access module) 2) Edit "editors" group and deny some CType (e.g. "HTML") 3) create in the page an element, CType "html" 4) switch to editor and click on the page in Page module without the patch: the "edit", "delete" and "disable" buttons are visible and lead to different errors (BTW: the "disable" button leads to an error, but seems to work) with the patch: no button is visible I only found this problem: while in list module, you can still access the "history/undo" function, and you can for example try to revert the changes. Basically, this is like editing the element. The buttons are clickable but don't work; still, the lack of a message or feedback may be confusing. Do you need a separate issue for that?
  5. Oli Bartsch commented on patch set 1 02/08/21, 09:32

    Reply

    Good catch. Yes, let's create a separate issue for it, since this patch only deals with page module.
  6. Richard Haeser voted on patch set 1 V +1 CR +1 02/09/21, 20:19

  7. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/10/21, 09:58

  8. Benjamin Franzke merged patch set 2 02/10/21, 09:58