Review main Merged

67632[TASK] Additional tests to check output of TypoScript settings for page titles

Richard Haeser CR +2 V +2 Normal +54 −9 updated 02/15/21, 09:00

Commit message

Verify the output of TypoScript settings config.pageTitleFirst and
config.pageTitleSeparator

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 914

  1. Richard Haeser uploaded patch set 1 02/03/21, 08:29

  2. Richard Haeser updated the commit message in patch set 2 02/03/21, 08:30

  3. TYPO3com voted on patch set 2 V -1 02/03/21, 08:36 Completed build in 05m 32s on Wed, 3 Feb, 08:36 AM Test Summary: 21927 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9208

  4. TYPO3com voted on patch set 1 V -1 02/03/21, 08:36 Completed build in 06m 43s on Wed, 3 Feb, 08:36 AM Test Summary: 28533 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9207

  5. TYPO3com voted on patch set 2 V +1 02/03/21, 14:47 Completed build in 06m 18s on Wed, 3 Feb, 02:47 PM Test Summary: 32594 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9214

  6. Martin Kutschker commented on patch set 2 V +1 CR +1 02/14/21, 17:40

    TitleTagRenderingTest.php:208

    What do you want to test with this variation? The numbers don't tell much about the intent. pageTitleSeparator = pipe pageTitleSeparator = dashWithSpaces or more like pageTitleSeparator = typoscriptText pageTitleSeparator = typoscriptStdwrap
  7. Benni Mack voted on patch set 2 V +2 CR +2 02/15/21, 08:39

  8. Benni Mack commented on patch set 2 02/15/21, 08:40

    TitleTagRenderingTest.php:208 Reply

    @richard: please merge once this is solved
  9. Richard Haeser uploaded patch set 3 02/15/21, 08:48

  10. Richard Haeser commented on patch set 3 02/15/21, 08:49

    TitleTagRenderingTest.php:208 Reply

    Done
  11. TYPO3com voted on patch set 3 V +1 02/15/21, 08:57 Completed build in 08m 09s on Mon, 15 Feb, 08:57 AM Test Summary: 32620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9531

  12. core-ci voted on patch set 3 V +1 02/15/21, 08:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/721

  13. Richard Haeser voted on patch set 3 V +2 CR +2 02/15/21, 09:00

  14. Richard Haeser merged patch set 4 02/15/21, 09:00