Review main Merged

67635[FEATURE] Implement lazy console command list

Benjamin Franzke CR +2 V +2 Hard +453 −93 updated 02/09/21, 09:39

Commit message

Based on the configuration syntax of the Symfony Console
feature https://github.com/symfony/symfony/pull/39851
…but implemented differently, using a registry pattern
rather then a lazy-object pattern (like symfony does).

Main motiviation for the registry pattern is following:
Symfony LazyCommand wrappers add quite some complexity only
for the sake of the list command, we already got lazy
commands (in terms of execution) as our CommandRegistry
implements the ConfigurationLoaderInterface that has been
introduced by 2017 to add support for lazy commands.

Now, that means we already got a registry for lazy commands,
so it is logical to add lazy description handling there as well.

We want to assure that the command list will never instantiate
any commands. This is in constrast to the Symfony core LazyCommand
approach, where legacy commands, that do not provide a compile time
description, would still be instantiated during console command list.

Also commands that return false in `isEnabled()` are now listed.
That means enabled state is only evaluated during runtime.
Therefore the special `dumpautoload` command is transformed into a
lowlevel command in order to be hidden dependending on being run
in composer-mode or not.

Review

  • Code review CR +2 Done
    • Helmut Hummel +2
    • Benni Mack +1
  • Verified V +2 Done
    • Helmut Hummel +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 41

Show 21 more files

Review log 821

  1. Benjamin Franzke uploaded patch set 1 02/03/21, 14:02

  2. TYPO3com voted on patch set 1 V +1 02/03/21, 14:09 Completed build in 06m 41s on Wed, 3 Feb, 02:09 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9213

  3. Benjamin Franzke uploaded patch set 2 02/03/21, 20:57

  4. TYPO3com voted on patch set 2 V +1 02/03/21, 21:04 Completed build in 07m 00s on Wed, 3 Feb, 09:04 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9237

  5. Benjamin Franzke uploaded patch set 3 02/04/21, 08:50

  6. TYPO3com voted on patch set 3 V -1 02/04/21, 08:57 Completed build in 06m 42s on Thu, 4 Feb, 08:57 AM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  7. TYPO3com commented on patch set 3 02/04/21, 08:59 Completed build in 14m 49s on Thu, 4 Feb, 08:59 AM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  8. TYPO3com commented on patch set 3 02/04/21, 09:03 Completed build in 27m 23s on Thu, 4 Feb, 09:03 AM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  9. TYPO3com commented on patch set 3 02/04/21, 09:14 Completed build in 50m 57s on Thu, 4 Feb, 09:14 AM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  10. TYPO3com commented on patch set 3 02/04/21, 09:16 Completed build in 1h 16m 13s on Thu, 4 Feb, 09:16 AM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  11. TYPO3com commented on patch set 3 02/04/21, 09:18 Completed build in 1h 43m 39s on Thu, 4 Feb, 09:18 AM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  12. TYPO3com commented on patch set 3 02/04/21, 09:22 Completed build in 2h 15m 08s on Thu, 4 Feb, 09:22 AM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  13. TYPO3com commented on patch set 3 02/04/21, 09:24 Completed build in 2h 48m 33s on Thu, 4 Feb, 09:24 AM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9248

  14. TYPO3com voted on patch set 3 V +1 02/04/21, 09:31 Completed build in 06m 26s on Thu, 4 Feb, 09:31 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9249

  15. Benjamin Franzke wrote 02/04/21, 13:51

    Topic set to cli
  16. Benjamin Franzke uploaded patch set 4 02/04/21, 16:16

  17. TYPO3com voted on patch set 4 V +1 02/04/21, 16:23 Completed build in 06m 47s on Thu, 4 Feb, 04:23 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9264

  18. core-ci voted on patch set 4 V +1 02/04/21, 16:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/379

  19. Benni Mack voted on patch set 4 V +1 CR +1 02/05/21, 16:13

  20. Helmut Hummel commented on patch set 4 V +2 CR +2 02/09/21, 09:39

    Thanks!
  21. Helmut Hummel merged patch set 5 02/09/21, 09:39