Review main Merged

67639[TASK] Adapt for upcoming Symfony 5.3 command tag properties

Benjamin Franzke CR +2 V +2 Easy +10 −0 updated 02/04/21, 08:44

Commit message

With the Symfony PR https://github.com/symfony/symfony/pull/39851
new depndency injection console.command tag properties are
supported, which allow to inject the description and
the hidden state into console commands.

In order to maintain a consistent console.command DI tag syntax
between Symfony and TYPO3 core, we now add forward compatibility
for this change.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Helmut Hummel +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Benni Mack +2
    • Helmut Hummel +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Benjamin Franzke uploaded patch set 1 02/03/21, 21:12

  2. TYPO3com voted on patch set 1 V +1 02/03/21, 21:18 Completed build in 06m 48s on Wed, 3 Feb, 09:18 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9239

  3. Helmut Hummel voted on patch set 1 V +1 CR +1 02/04/21, 07:21

  4. Benni Mack voted on patch set 1 V +2 CR +2 02/04/21, 08:43

  5. Benjamin Franzke voted on patch set 1 V +2 CR +2 02/04/21, 08:43

  6. Benjamin Franzke merged patch set 2 02/04/21, 08:44