Review main Merged

67640[TASK] Migrate TreeToolbar to TypeScript

Benni Mack CR +2 V +2 Hard +198 −219 updated 02/04/21, 12:29

Commit message

This change migrate the TreeToolbar (used in FormEngine
Category Tree for example) to TypeScript,
removing effectively one RequireJS call and replacing
it with a native TypeScript component.

Removing the rest of the jQuery will be part of a
separate effort.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1216

  1. Benni Mack uploaded patch set 1 02/04/21, 10:37

  2. TYPO3com voted on patch set 1 V +1 02/04/21, 10:43 Completed build in 06m 07s on Thu, 4 Feb, 10:43 AM Test Summary: 32584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9252

  3. Andreas Kienast commented on patch set 1 V +1 02/04/21, 10:51

    TreeToolbar.ts:14 Unresolved

    Why is this necessary?

    TreeToolbar.ts:138 Unresolved

    Alright, our linter is not perfect yet, as the curly belongs into the same line as the function name

    TreeToolbar.ts:149 Unresolved

    What's the reason for this comment? I've removed the line and still was able to compile the code. This looks like some left-over instruction.
  4. Benni Mack uploaded patch set 2 02/04/21, 10:52

  5. Benni Mack uploaded patch set 3 02/04/21, 10:55

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 02/04/21, 10:55

  7. Oliver Hader commented on patch set 3 02/04/21, 10:59

    TreeToolbar.ts:81

    const inputEl = event.target as HTMLInputElement;

    TreeToolbar.ts:82

    Does it always exist? Or `if (this.tree.node.length > 0) {...}`?

    TreeToolbar.ts:144

    `const`

    TreeToolbar.ts:147

    `const`
  8. TYPO3com voted on patch set 2 V +1 02/04/21, 11:00 Completed build in 07m 52s on Thu, 4 Feb, 11:00 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9253

  9. TYPO3com voted on patch set 3 V +1 02/04/21, 11:02 Completed build in 06m 59s on Thu, 4 Feb, 11:02 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9254

  10. Benni Mack uploaded patch set 4 02/04/21, 11:52

  11. Benni Mack commented on patch set 4 02/04/21, 11:53

    TreeToolbar.ts:81 Reply

    Ack

    TreeToolbar.ts:82 Reply

    Ack

    TreeToolbar.ts:144 Reply

    Ack

    TreeToolbar.ts:147 Reply

    Ack
  12. TYPO3com voted on patch set 4 V +1 02/04/21, 12:00 Completed build in 07m 42s on Thu, 4 Feb, 12:00 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9256

  13. Oliver Hader voted on patch set 4 CR +1 02/04/21, 12:03

  14. Andreas Kienast voted on patch set 4 V +1 CR +1 02/04/21, 12:15

  15. Benni Mack voted on patch set 4 V +2 CR +2 02/04/21, 12:29

  16. Benni Mack merged patch set 5 02/04/21, 12:29