67640[TASK] Migrate TreeToolbar to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Andreas Kienast +1
- Oliver Hader +1
-
Verified V +2 Done
- Benni Mack +2
- Andreas Kienast +1
- TYPO3com +1 CI
Issues 1
Files 4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts+3 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/TreeToolbar.ts11new+175 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/TreeToolbar.js+19 −214
Review log 1216
-
Benni Mack uploaded patch set 1 02/04/21, 10:37
-
TYPO3com voted on patch set 1 V +1 02/04/21, 10:43 Completed build in 06m 07s on Thu, 4 Feb, 10:43 AM Test Summary: 32584 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9252
-
Andreas Kienast commented on patch set 1 V +1 02/04/21, 10:51
TreeToolbar.ts:138UnresolvedAlright, our linter is not perfect yet, as the curly belongs into the same line as the function nameTreeToolbar.ts:149UnresolvedWhat's the reason for this comment? I've removed the line and still was able to compile the code. This looks like some left-over instruction. -
Benni Mack uploaded patch set 2 02/04/21, 10:52
-
Benni Mack uploaded patch set 3 02/04/21, 10:55
-
Andreas Kienast voted on patch set 3 V +1 CR +1 02/04/21, 10:55
-
Oliver Hader commented on patch set 3 02/04/21, 10:59
TreeToolbar.ts:81const inputEl = event.target as HTMLInputElement;TreeToolbar.ts:82Does it always exist? Or `if (this.tree.node.length > 0) {...}`?TreeToolbar.ts:144`const`TreeToolbar.ts:147`const` -
TYPO3com voted on patch set 2 V +1 02/04/21, 11:00 Completed build in 07m 52s on Thu, 4 Feb, 11:00 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9253
-
TYPO3com voted on patch set 3 V +1 02/04/21, 11:02 Completed build in 06m 59s on Thu, 4 Feb, 11:02 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9254
-
Benni Mack uploaded patch set 4 02/04/21, 11:52
-
Benni Mack commented on patch set 4 02/04/21, 11:53
TreeToolbar.ts:81ReplyAckTreeToolbar.ts:82ReplyAckTreeToolbar.ts:144ReplyAckTreeToolbar.ts:147ReplyAck -
TYPO3com voted on patch set 4 V +1 02/04/21, 12:00 Completed build in 07m 42s on Thu, 4 Feb, 12:00 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9256
-
Oliver Hader voted on patch set 4 CR +1 02/04/21, 12:03
-
Andreas Kienast voted on patch set 4 V +1 CR +1 02/04/21, 12:15
-
Benni Mack voted on patch set 4 V +2 CR +2 02/04/21, 12:29
-
Benni Mack merged patch set 5 02/04/21, 12:29
TreeToolbar.ts:14Unresolved