67641[TASK] gitlab-ci votes patches on gerrit
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Richard Haeser +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oli Bartsch +1
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 4
Review log 1822
-
Christian Kuhn uploaded patch set 1 02/04/21, 13:35
-
Richard Haeser voted on patch set 1 CR +1 02/04/21, 13:38
-
TYPO3com voted on patch set 1 V +1 02/04/21, 13:42 Completed build in 06m 14s on Thu, 4 Feb, 01:42 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9260
-
Oli Bartsch voted on patch set 1 V +1 CR +1 02/04/21, 13:46
-
Stephan Großberndt voted on patch set 1 CR +1 02/04/21, 13:47
-
core-ci voted on patch set 1 CR +1 02/04/21, 13:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/374
-
Christian Kuhn commented on patch set 1 CR -1 02/04/21, 13:52
ah sorry. core-ci should verify, not code-review ... -
Richard Haeser commented on patch set 1 CR -1 02/04/21, 13:52
notify.yml:18Is it right, it gives a code review in stead of a verify? -
Oli Bartsch commented on patch set 1 V -1 CR 0 02/04/21, 13:53
Should be verified -1/+1 instead of code review -
Richard Haeser commented on patch set 1 CR 0 02/04/21, 13:53
Reply
Ah you were first :Pnotify.yml:18ReplySee comment by Christian -
Stephan Großberndt commented on patch set 1 02/04/21, 13:54
notify.yml:8Put this code into a script file to be called with argument for positive/negative vote to avoid duplicate code?notify.yml:17Is it possible to "hack" the gitlab-ci by adding a specially crafted $MESSAGE? If yes, what would be the implications, how to circumvent? -
Christian Kuhn uploaded patch set 2 02/04/21, 13:54
-
Christian Kuhn commented on patch set 2 02/04/21, 13:55
should vote correctly now ;) -
Christian Kuhn commented on patch set 2 02/04/21, 13:58
notify.yml:8Replywell, i think that's not worth it ... don't wanna create a lot of fuzz for this tiny duplication ;)notify.yml:17Reply Unresolvedyes. you could change this part to make core-ci message things on gerrit for *your* patch this way ... imho not an issue.notify.yml:18Replyshould be solved now. -
core-ci voted on patch set 2 V +1 02/04/21, 14:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/376
-
TYPO3com voted on patch set 2 V +1 02/04/21, 14:10 Completed build in 15m 27s on Thu, 4 Feb, 02:10 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9262
-
Richard Haeser voted on patch set 2 V +1 CR +1 02/04/21, 14:15
-
Richard Haeser commented on patch set 2 02/04/21, 14:16
Maybe we should test the -1 vote as well? -
Oli Bartsch voted on patch set 2 V +1 CR +1 02/04/21, 14:18
-
Oli Bartsch commented on patch set 2 02/04/21, 14:19
Reply
See last vote in https://review.typo3.org/c/Packages/TYPO3.CMS/+/67580. So the functionality was tested. Just the label changed. -
Christian Kuhn commented on patch set 2 V +2 CR +2 02/04/21, 14:25
We'll pick this patch for now since it gives us an overview of the new CI, it's stability and speed. We'll however change the curl call later again, but I need some time to prepare it. -
Christian Kuhn merged patch set 3 02/04/21, 14:35