Review main Merged

67647[TASK] Inject cache into SiteConfiguration

Benjamin Franzke CR +2 V +2 Normal +35 −33 updated 02/11/21, 21:24

Commit message

Do not use global state by looking up the CacheManager from
GeneralUtility, when we can actually inject the required cache.

The core cache is available from early bootstrap, therefore
we do not need to wait for CacheManager to be available, and
can inject it right away.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 9

Review log 1435

Show 410 earlier messages
  1. Benjamin Franzke uploaded patch set 1 02/05/21, 07:13

  2. TYPO3com voted on patch set 1 V -1 02/05/21, 07:23 Completed build in 09m 43s on Fri, 5 Feb, 07:23 AM Test Summary: 5256 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9274

  3. core-ci voted on patch set 1 V -1 02/05/21, 07:30 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/392

  4. Benjamin Franzke uploaded patch set 2 02/05/21, 07:43

  5. TYPO3com voted on patch set 2 V -1 02/05/21, 07:50 Completed build in 06m 15s on Fri, 5 Feb, 07:50 AM Test Summary: 303 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9276

  6. core-ci voted on patch set 2 V -1 02/05/21, 07:54 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/394

  7. Benjamin Franzke uploaded patch set 3 02/05/21, 08:09

  8. TYPO3com voted on patch set 3 V -1 02/05/21, 08:17 Completed build in 08m 17s on Fri, 5 Feb, 08:17 AM Test Summary: 153 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9277

  9. Benjamin Franzke uploaded patch set 4 02/05/21, 08:18

  10. core-ci voted on patch set 3 V -1 02/05/21, 08:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/395

  1. TYPO3com voted on patch set 4 V -1 02/05/21, 08:36 Completed build in 16m 03s on Fri, 5 Feb, 08:36 AM Test Summary: 3 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9282

  2. core-ci voted on patch set 4 V -1 02/05/21, 08:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/400

  3. Benjamin Franzke uploaded patch set 5 02/05/21, 08:43

  4. Benjamin Franzke uploaded patch set 6 02/05/21, 08:45

  5. TYPO3com voted on patch set 5 V -1 02/05/21, 08:51 Completed build in 08m 09s on Fri, 5 Feb, 08:51 AM Test Summary: 4 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9283

  6. TYPO3com voted on patch set 6 V +1 02/05/21, 08:53 Completed build in 07m 50s on Fri, 5 Feb, 08:53 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9284

  7. core-ci voted on patch set 5 V +1 02/05/21, 08:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/401

  8. core-ci voted on patch set 6 V +1 02/05/21, 08:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/402

  9. Benjamin Franzke rebased onto patch set 7 02/05/21, 13:51

  10. TYPO3com voted on patch set 7 V -1 02/05/21, 14:00 Completed build in 09m 00s on Fri, 5 Feb, 02:00 PM Test Summary: 1 of 32458 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9295

  11. core-ci voted on patch set 7 V -1 02/05/21, 14:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/412

  12. TYPO3com voted on patch set 7 V +1 02/05/21, 18:30 Completed build in 08m 02s on Fri, 5 Feb, 06:30 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9313

  13. Benjamin Franzke rebased onto patch set 8 02/09/21, 16:31

  14. Benjamin Franzke wrote 02/09/21, 16:33

    Topic set to di
  15. TYPO3com voted on patch set 8 V +1 02/09/21, 16:41 Completed build in 09m 49s on Tue, 9 Feb, 04:41 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9403

  16. core-ci voted on patch set 8 V +1 02/09/21, 16:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/540

  17. Benjamin Franzke rebased onto patch set 9 02/10/21, 05:30

  18. TYPO3com voted on patch set 9 V -1 02/10/21, 05:42 Completed build in 12m 23s on Wed, 10 Feb, 05:42 AM Test Summary: 1 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9427

  19. core-ci voted on patch set 9 V +1 02/10/21, 05:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/567

  20. TYPO3com commented on patch set 9 02/10/21, 06:22 Completed build in 1h 04m 45s on Wed, 10 Feb, 06:22 AM Test Summary: 1 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9427

  21. TYPO3com voted on patch set 9 V +1 02/10/21, 07:16 Completed build in 08m 23s on Wed, 10 Feb, 07:16 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9432

  22. Jörg Bösche voted on patch set 9 CR +1 02/11/21, 19:07

  23. Christian Kuhn voted on patch set 9 V +1 CR +1 02/11/21, 21:18

  24. Richard Haeser voted on patch set 9 V +2 CR +2 02/11/21, 21:24

  25. Richard Haeser merged patch set 10 02/11/21, 21:24