67648[TASK] Inject dependencies into ProviderConfigurationLoader
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/ExpressionLanguage/ProviderConfigurationLoader.php+21 −15
- typo3/sysext/core/Configuration/Services.yaml+5 −0
- typo3/sysext/core/Tests/Unit/Configuration/TypoScript/ConditionMatching/AbstractConditionMatcherTest.php+5 −0
- typo3/sysext/core/Tests/Unit/ExpressionLanguage/ResolverTest.php+6 −6
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+5 −4
Review log 1125
-
Benjamin Franzke uploaded patch set 1 02/05/21, 09:35
-
Benjamin Franzke uploaded patch set 2 02/05/21, 09:57
-
TYPO3com voted on patch set 2 V +1 02/05/21, 10:03 Completed build in 06m 33s on Fri, 5 Feb, 10:03 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9287
-
core-ci voted on patch set 2 V +1 02/05/21, 10:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/405
-
core-ci voted on patch set 1 V -1 02/05/21, 10:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/404
-
TYPO3com voted on patch set 1 V -1 02/05/21, 10:40 Completed build in 1h 04m 21s on Fri, 5 Feb, 10:40 AM Test Summary: 6298 of 28345 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9286
-
Benjamin Franzke rebased onto patch set 3 02/05/21, 13:51
-
TYPO3com voted on patch set 3 V -1 02/05/21, 14:00 Completed build in 08m 52s on Fri, 5 Feb, 02:00 PM Test Summary: 32574 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9296
-
core-ci voted on patch set 3 V +1 02/05/21, 14:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/413
-
TYPO3com commented on patch set 3 02/05/21, 18:31 Completed build in 07m 48s on Fri, 5 Feb, 06:31 PM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9314
-
TYPO3com voted on patch set 3 V +1 02/05/21, 18:42 Completed build in 26m 49s on Fri, 5 Feb, 06:42 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9314
-
Benjamin Franzke rebased onto patch set 4 02/09/21, 16:31
-
Benjamin Franzke wrote 02/09/21, 16:33
Topic set to di -
TYPO3com voted on patch set 4 V +1 02/09/21, 16:41 Completed build in 09m 47s on Tue, 9 Feb, 04:41 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9404
-
core-ci voted on patch set 4 V +1 02/09/21, 16:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/541
-
Benjamin Franzke rebased onto patch set 5 02/10/21, 05:30
-
TYPO3com voted on patch set 5 V +1 02/10/21, 05:41 Completed build in 11m 08s on Wed, 10 Feb, 05:41 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9428
-
core-ci voted on patch set 5 V +1 02/10/21, 05:47 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/568
-
Benjamin Franzke rebased onto patch set 6 02/19/21, 20:29
-
core-ci voted on patch set 6 V +1 02/19/21, 20:43 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/862
-
TYPO3com voted on patch set 6 V +1 02/19/21, 20:43 Completed build in 14m 09s on Fri, 19 Feb, 08:43 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9642
-
Benni Mack commented on patch set 6 CR +1 02/19/21, 21:28
much nicer now! -
Benni Mack voted on patch set 6 V +1 02/19/21, 21:50
-
Christian Kuhn voted on patch set 6 V +2 CR +2 02/22/21, 14:11
-
Christian Kuhn merged patch set 7 02/22/21, 14:11