Review main Merged

67649[TASK] Improve page access failure log entries

Oli Bartsch CR +2 V +2 Easy +21 −4 updated 02/11/21, 12:22

Commit message

Page access failure log entries emitted by the
TypoScriptFrontendController previously only
included the same basic information, also shown
to the user in the frontend. With this information
it was nearly impossible for integrators to debug
such errors further, making the whole entry log
more or less superfluous.

Therefore, all log entries for page access failures
now include the requested URL and the requested
page ID.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 1727

Show 12 earlier messages
  1. Oli Bartsch uploaded patch set 1 02/05/21, 10:41

  2. TYPO3com voted on patch set 1 V +1 02/05/21, 10:48 Completed build in 06m 34s on Fri, 5 Feb, 10:48 AM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9289

  1. core-ci voted on patch set 1 V +1 02/05/21, 10:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/407

  2. Jens Ulrich voted on patch set 1 CR +1 02/05/21, 11:32

  3. Markus Klein commented on patch set 1 CR -1 02/06/21, 21:51

    Generally, besides my comment, I do not want my log to be spammed with error(!) messages, just because some bot does strange things with urls. Please consider this and only log in a way that does not flood the log with useless things.

    TypoScriptFrontendController.php:3526

    I would use the second parameter of error() to pass the request as object directly. ['request' => $request]
  4. Oli Bartsch uploaded patch set 2 02/08/21, 09:23

  5. Oli Bartsch commented on patch set 2 02/08/21, 09:30

    Reply

    This patch mostly just enriches already existing log entries with necessary information about the request. Otherwise the entry would really be useless since integrators can not reproduce or debug such entry in any way. So would you like me to remove the additional log entries added by this patch, or what is your suggestion?

    TypoScriptFrontendController.php:3526 Reply

    I added the request information as second parameter. However, using the whole request object does not work. At least not for the default FileWriter.
  6. TYPO3com voted on patch set 2 V +1 02/08/21, 09:31 Completed build in 07m 38s on Mon, 8 Feb, 09:31 AM Test Summary: 32583 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9343

  7. core-ci voted on patch set 2 V +1 02/08/21, 09:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/472

  8. Benjamin Franzke commented on patch set 2 02/08/21, 18:01

    TypoScriptFrontendController.php:3522

    We should check if the normalizedParams attribute actually exists and has proper type (instanceof check).

    TypoScriptFrontendController.php:3526 Reply

    I agree with Oliver, the (Server)RequestInterface cannot be serialized.
  9. Oli Bartsch uploaded patch set 3 02/08/21, 20:58

  10. Oli Bartsch commented on patch set 3 02/08/21, 20:59

    TypoScriptFrontendController.php:3522 Reply

    Done
  11. TYPO3com voted on patch set 3 V +1 02/08/21, 21:07 Completed build in 08m 29s on Mon, 8 Feb, 09:07 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9360

  12. core-ci voted on patch set 3 V +1 02/08/21, 21:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/498

  13. Benni Mack updated the commit message in patch set 4 02/08/21, 21:15

  14. Benni Mack commented on patch set 4 02/08/21, 21:15

    I took the liberty of only adding this to v11 (just in case)
  15. TYPO3com voted on patch set 4 V +1 02/08/21, 21:23 Completed build in 08m 20s on Mon, 8 Feb, 09:23 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9362

  16. core-ci voted on patch set 4 V +1 02/08/21, 21:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/500

  17. Markus Klein commented on patch set 4 02/08/21, 21:30

    Reply

    If I see that correctly you added a few. Lines 971 ff, 1189, 1919, 1930, 1954 Specifically the first ones will add loads of log entries, when "bots" are playing around, like: example.com/news/page/1/ example.com/news/page/2/ example.com/news/page/<any random number>/

    TypoScriptFrontendController.php:3526 Reply

    Alright, didn't have this in mind. Clear then.
  18. Oli Bartsch uploaded patch set 5 02/10/21, 22:23

  19. TYPO3com voted on patch set 5 V +1 02/10/21, 22:31 Completed build in 07m 55s on Wed, 10 Feb, 10:31 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9452

  20. Oli Bartsch commented on patch set 5 02/10/21, 22:31

    Reply

    I personally don't see a problem with such log entries, since you have exactly the same when bots try different type nums. However, this patch now only enriches the already existing log entries.
  21. core-ci voted on patch set 5 V +1 02/10/21, 22:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/614

  22. Christian Kuhn voted on patch set 5 V +1 CR +1 02/11/21, 09:42

  23. Markus Klein voted on patch set 5 V +1 CR +1 02/11/21, 12:07

  24. Christian Kuhn voted on patch set 5 V +2 CR +2 02/11/21, 12:22

  25. Christian Kuhn merged patch set 6 02/11/21, 12:22