Review 10.4 Merged

67657[TASK] Load TypeScript declarations for sortablejs

Andreas Kienast CR +2 V +2 Easy +11 −5 updated 02/06/21, 21:21

Commit message

This patch adds the TypeScript declaration for the sortablejs library.
Since the imported module has a different naming, the PageRenderer needs
both the new module name ("sortablejs") and the old name ("Sortable") as
this would be a breaking change, otherwise.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 37

  1. Andreas Kienast uploaded patch set 1 02/06/21, 16:45

  2. TYPO3com voted on patch set 1 V -1 02/06/21, 16:56 Completed build in 10m 25s on Sat, 6 Feb, 04:56 PM Test Summary: 1 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1059

  3. TYPO3com commented on patch set 1 02/06/21, 17:25 Completed build in 50m 15s on Sat, 6 Feb, 05:25 PM Test Summary: 5 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1059

  4. TYPO3com commented on patch set 1 02/06/21, 17:28 Completed build in 1h 32m 36s on Sat, 6 Feb, 05:28 PM Test Summary: 5 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1059

  5. TYPO3com voted on patch set 1 V +1 02/06/21, 20:21 Completed build in 09m 02s on Sat, 6 Feb, 08:21 PM Test Summary: 75308 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1060

  6. Andreas Kienast voted on patch set 1 V +2 CR +2 02/06/21, 21:21

  7. Andreas Kienast merged patch set 2 02/06/21, 21:21