Review main Merged

67658[TASK] Load TypeScript declarations for sortablejs

Andreas Kienast CR +2 V +2 Normal +47 −6 updated 02/06/21, 21:21

Commit message

This patch adds the TypeScript declaration for the sortablejs library.
Since the imported module has a different naming, the PageRenderer needs
both the new module name ("sortablejs") and the old name ("Sortable") as
this would be a breaking change, otherwise.

In the master patch, the old module name has been declared deprecated.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 9

Review log 512

  1. Andreas Kienast uploaded patch set 1 02/06/21, 16:52

  2. TYPO3com voted on patch set 1 V -1 02/06/21, 17:01 Completed build in 08m 28s on Sat, 6 Feb, 05:01 PM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9331

  3. TYPO3com commented on patch set 1 02/06/21, 17:12 Completed build in 28m 26s on Sat, 6 Feb, 05:12 PM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9331

  4. Andreas Kienast uploaded patch set 2 02/06/21, 17:19

  5. TYPO3com voted on patch set 2 V -1 02/06/21, 17:28 Completed build in 08m 16s on Sat, 6 Feb, 05:28 PM Test Summary: 2 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9332

  6. TYPO3com commented on patch set 2 02/06/21, 17:30 Completed build in 19m 06s on Sat, 6 Feb, 05:30 PM Test Summary: 4 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9332

  7. core-ci voted on patch set 1 V +1 02/06/21, 19:16 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/447

  8. core-ci voted on patch set 2 V +1 02/06/21, 19:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/448

  9. TYPO3com voted on patch set 2 V +1 02/06/21, 20:16 Completed build in 08m 09s on Sat, 6 Feb, 08:16 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9333

  10. Benni Mack voted on patch set 2 V +1 CR +1 02/06/21, 20:29

  11. Andreas Kienast voted on patch set 2 V +2 CR +2 02/06/21, 21:21

  12. Andreas Kienast merged patch set 3 02/06/21, 21:21