Review 10.4 Merged

67659[BUGFIX] Fix frameset module property for FileList

Andreas Kienast CR +2 V +2 Easy +11 −4 updated 02/08/21, 18:43

Commit message

BackendController::generateJavascript() creates the
top.fsMod object to provide frameset modules an easy
way of storing their state. The FileList module e.g.
stores the current folder identifier. Therefore, after
switching back to the FileList module, the previously
selected folder is used.

This behaviour is now restored by replacing the
"instanceof" check, which always evaluated to FALSE,
with a typeof check. It's furthermore now ensured
that the id will always be set, even if recentIds
is not yet an object.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 38

  1. Andreas Kienast uploaded patch set 1 02/06/21, 21:47

  2. TYPO3com voted on patch set 1 V -1 02/06/21, 21:58 Completed build in 10m 31s on Sat, 6 Feb, 09:57 PM Test Summary: 1 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1061

  3. TYPO3com commented on patch set 1 02/06/21, 22:00 Completed build in 23m 26s on Sat, 6 Feb, 10:00 PM Test Summary: 5 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1061

  4. TYPO3com commented on patch set 1 02/06/21, 22:17 Completed build in 08m 31s on Sat, 6 Feb, 10:17 PM Test Summary: 2 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1062

  5. TYPO3com commented on patch set 1 02/08/21, 05:39 Completed build in 09m 58s on Mon, 8 Feb, 05:39 AM Test Summary: 2 of 75793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1069

  6. TYPO3com voted on patch set 1 V +1 02/08/21, 15:13 Completed build in 11m 07s on Mon, 8 Feb, 03:13 PM Test Summary: 75298 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1071

  7. Andreas Kienast voted on patch set 1 V +2 CR +2 02/08/21, 18:43

  8. Andreas Kienast merged patch set 2 02/08/21, 18:43