Review main Merged

67662[TASK] Migrate SvgTree items to TypeScript

Benni Mack CR +2 V +2 Nightmare +2330 −2525 updated 02/09/21, 13:23

Commit message

This change migrates all left-over components of
* SvgTree
* SelectTree (a.k.a. CategoryTree)
* and PageTree

to TypeScript adding types in various places
to make the code less error-prone.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 29

Show 9 more files

Review log 2044

Show 719 earlier messages
  1. Benni Mack uploaded patch set 1 02/08/21, 10:28

  2. Benni Mack updated the commit message in patch set 2 02/08/21, 10:30

  3. TYPO3com voted on patch set 2 V -1 02/08/21, 10:37 Completed build in 07m 25s on Mon, 8 Feb, 10:37 AM Test Summary: 32583 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9345

  4. TYPO3com voted on patch set 1 V -1 02/08/21, 10:38 Completed build in 09m 41s on Mon, 8 Feb, 10:38 AM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9344

  5. core-ci voted on patch set 1 V -1 02/08/21, 10:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/473

  6. Oliver Hader marked it work in progress 02/08/21, 10:40

  7. core-ci voted on patch set 2 V -1 02/08/21, 10:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/474

  8. Oliver Hader uploaded patch set 3 02/08/21, 20:06

  9. TYPO3com voted on patch set 3 V -1 02/08/21, 20:18 Completed build in 10m 57s on Mon, 8 Feb, 08:18 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9358

  10. core-ci voted on patch set 3 V -1 02/08/21, 20:18 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/496

  11. Benni Mack uploaded patch set 4 02/08/21, 20:54

  12. TYPO3com voted on patch set 4 V -1 02/08/21, 21:03 Completed build in 08m 18s on Mon, 8 Feb, 09:03 PM Test Summary: 10 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9359

  13. core-ci voted on patch set 4 V -1 02/08/21, 21:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/497

  14. Benni Mack uploaded patch set 5 02/08/21, 21:13

  15. TYPO3com voted on patch set 5 V -1 02/08/21, 21:22 Completed build in 08m 58s on Mon, 8 Feb, 09:22 PM Test Summary: 2 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9361

  16. core-ci voted on patch set 5 V -1 02/08/21, 21:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/499

  17. Benni Mack uploaded patch set 6 02/08/21, 22:46

  18. TYPO3com voted on patch set 6 V +1 02/08/21, 22:55 Completed build in 09m 23s on Mon, 8 Feb, 10:55 PM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9364

  19. core-ci voted on patch set 6 V +1 02/08/21, 22:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/501

  1. Benni Mack updated the commit message in patch set 7 02/09/21, 07:11

  2. Benni Mack updated the commit message in patch set 8 02/09/21, 07:12

  3. Benni Mack marked it ready for review 02/09/21, 07:13

  4. TYPO3com voted on patch set 7 V +1 02/09/21, 07:20 Completed build in 09m 11s on Tue, 9 Feb, 07:20 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9368

  5. TYPO3com voted on patch set 8 V -1 02/09/21, 07:21 Completed build in 08m 48s on Tue, 9 Feb, 07:21 AM Test Summary: 1 of 32828 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9369

  6. core-ci voted on patch set 7 V +1 02/09/21, 07:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/506

  7. core-ci voted on patch set 8 V +1 02/09/21, 07:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/507

  8. TYPO3com voted on patch set 8 V +1 02/09/21, 07:59 Completed build in 55m 49s on Tue, 9 Feb, 07:59 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9369

  9. Benni Mack uploaded patch set 9 02/09/21, 09:18

  10. TYPO3com voted on patch set 9 V +1 02/09/21, 09:26 Completed build in 08m 02s on Tue, 9 Feb, 09:26 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9371

  11. core-ci voted on patch set 9 V +1 02/09/21, 09:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/509

  12. Georg Ringer voted on patch set 9 V +1 CR +1 02/09/21, 09:38

  13. Oliver Hader voted on patch set 9 CR -1 02/09/21, 09:58

  14. Oliver Hader uploaded patch set 10 02/09/21, 10:10

  15. Oliver Hader commented on patch set 10 CR -1 02/09/21, 10:12

    Still, the category tree issue with FormEngine has to be tested (and fixed)
  16. TYPO3com voted on patch set 10 V +1 02/09/21, 10:19 Completed build in 09m 01s on Tue, 9 Feb, 10:19 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9377

  17. core-ci voted on patch set 10 V +1 02/09/21, 10:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/515

  18. Oliver Hader commented on patch set 10 02/09/21, 10:55

    SelectTree.ts:38 Unresolved

    Wrong scoping of `thisArg`, probably wrong before
  19. Oliver Hader uploaded patch set 11 02/09/21, 12:55

  20. Oliver Hader voted on patch set 11 V +1 CR +1 02/09/21, 12:58

  21. TYPO3com voted on patch set 11 V -1 02/09/21, 13:06 Completed build in 10m 57s on Tue, 9 Feb, 01:06 PM Test Summary: 10 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9387

  22. core-ci voted on patch set 11 V +1 02/09/21, 13:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/525

  23. TYPO3com voted on patch set 11 V +1 02/09/21, 13:21 Completed build in 36m 48s on Tue, 9 Feb, 01:21 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9387

  24. Georg Ringer voted on patch set 11 V +2 CR +2 02/09/21, 13:22

  25. Georg Ringer merged patch set 12 02/09/21, 13:23