67662[TASK] Migrate SvgTree items to TypeScript
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oliver Hader +1
-
Verified V +2 Done
- Georg Ringer +2
- Oliver Hader +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 2
Files 29
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Enum/IconTypes.tsnew+29 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTree.ts1new+198 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTreeElement.ts+20 −21
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/TreeToolbar.ts+5 −11
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTree.tsnew+733 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeDragDrop.ts+11 −12
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeDragHandler.ts+11 −10
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeElement.ts+2 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/TreeNode.tsnew+69 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenu.ts+1 −5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Icons.ts+1 −17
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.tsnew+1203 −0
- Build/types/TYPO3/index.d.ts+0 −7
- Build/package.json+1 −0
- Build/yarn.lock+5 −0
- typo3/sysext/backend/Classes/Controller/Page/TreeController.php+2 −1
- typo3/sysext/backend/Classes/Form/Element/SelectTreeElement.php+2 −6
- typo3/sysext/backend/Resources/Public/JavaScript/Enum/IconTypes.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTree.js+1 −213
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTreeElement.js+1 −1
Show 9 more files
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/TreeToolbar.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+1 −801
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragDrop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragHandler.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeElement.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/TreeNode.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Icons.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+1 −1411
Review log 2044
Show 719 earlier messages
-
Benni Mack uploaded patch set 1 02/08/21, 10:28
-
Benni Mack updated the commit message in patch set 2 02/08/21, 10:30
-
TYPO3com voted on patch set 2 V -1 02/08/21, 10:37 Completed build in 07m 25s on Mon, 8 Feb, 10:37 AM Test Summary: 32583 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9345
-
TYPO3com voted on patch set 1 V -1 02/08/21, 10:38 Completed build in 09m 41s on Mon, 8 Feb, 10:38 AM Test Summary: 1 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9344
-
core-ci voted on patch set 1 V -1 02/08/21, 10:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/473
-
Oliver Hader marked it work in progress 02/08/21, 10:40
-
core-ci voted on patch set 2 V -1 02/08/21, 10:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/474
-
Oliver Hader uploaded patch set 3 02/08/21, 20:06
-
TYPO3com voted on patch set 3 V -1 02/08/21, 20:18 Completed build in 10m 57s on Mon, 8 Feb, 08:18 PM Test Summary: 32575 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9358
-
core-ci voted on patch set 3 V -1 02/08/21, 20:18 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/496
-
Benni Mack uploaded patch set 4 02/08/21, 20:54
-
TYPO3com voted on patch set 4 V -1 02/08/21, 21:03 Completed build in 08m 18s on Mon, 8 Feb, 09:03 PM Test Summary: 10 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9359
-
core-ci voted on patch set 4 V -1 02/08/21, 21:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/497
-
Benni Mack uploaded patch set 5 02/08/21, 21:13
-
TYPO3com voted on patch set 5 V -1 02/08/21, 21:22 Completed build in 08m 58s on Mon, 8 Feb, 09:22 PM Test Summary: 2 of 32816 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9361
-
core-ci voted on patch set 5 V -1 02/08/21, 21:24 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/499
-
Benni Mack uploaded patch set 6 02/08/21, 22:46
-
TYPO3com voted on patch set 6 V +1 02/08/21, 22:55 Completed build in 09m 23s on Mon, 8 Feb, 10:55 PM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9364
-
core-ci voted on patch set 6 V +1 02/08/21, 22:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/501
-
Benni Mack updated the commit message in patch set 7 02/09/21, 07:11
-
Benni Mack updated the commit message in patch set 8 02/09/21, 07:12
-
Benni Mack marked it ready for review 02/09/21, 07:13
-
TYPO3com voted on patch set 7 V +1 02/09/21, 07:20 Completed build in 09m 11s on Tue, 9 Feb, 07:20 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9368
-
TYPO3com voted on patch set 8 V -1 02/09/21, 07:21 Completed build in 08m 48s on Tue, 9 Feb, 07:21 AM Test Summary: 1 of 32828 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9369
-
core-ci voted on patch set 7 V +1 02/09/21, 07:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/506
-
core-ci voted on patch set 8 V +1 02/09/21, 07:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/507
-
TYPO3com voted on patch set 8 V +1 02/09/21, 07:59 Completed build in 55m 49s on Tue, 9 Feb, 07:59 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9369
-
Benni Mack uploaded patch set 9 02/09/21, 09:18
-
TYPO3com voted on patch set 9 V +1 02/09/21, 09:26 Completed build in 08m 02s on Tue, 9 Feb, 09:26 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9371
-
core-ci voted on patch set 9 V +1 02/09/21, 09:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/509
-
Georg Ringer voted on patch set 9 V +1 CR +1 02/09/21, 09:38
-
Oliver Hader voted on patch set 9 CR -1 02/09/21, 09:58
-
Oliver Hader uploaded patch set 10 02/09/21, 10:10
-
Oliver Hader commented on patch set 10 CR -1 02/09/21, 10:12
Still, the category tree issue with FormEngine has to be tested (and fixed) -
TYPO3com voted on patch set 10 V +1 02/09/21, 10:19 Completed build in 09m 01s on Tue, 9 Feb, 10:19 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9377
-
core-ci voted on patch set 10 V +1 02/09/21, 10:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/515
-
Oliver Hader commented on patch set 10 02/09/21, 10:55
SelectTree.ts:38UnresolvedWrong scoping of `thisArg`, probably wrong before -
Oliver Hader uploaded patch set 11 02/09/21, 12:55
-
Oliver Hader voted on patch set 11 V +1 CR +1 02/09/21, 12:58
-
TYPO3com voted on patch set 11 V -1 02/09/21, 13:06 Completed build in 10m 57s on Tue, 9 Feb, 01:06 PM Test Summary: 10 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9387
-
core-ci voted on patch set 11 V +1 02/09/21, 13:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/525
-
TYPO3com voted on patch set 11 V +1 02/09/21, 13:21 Completed build in 36m 48s on Tue, 9 Feb, 01:21 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9387
-
Georg Ringer voted on patch set 11 V +2 CR +2 02/09/21, 13:22
-
Georg Ringer merged patch set 12 02/09/21, 13:23