Review main Merged

67663[TASK] Drop unneeded renderElement from lit-helper

Benjamin Franzke CR +2 V +2 Easy +26 −13 updated 02/08/21, 17:46

Commit message

renderElement() was added in patchset 2 of #93446.
The code was then refactored to use renderHTML, but the method was
forgotten to be removed in the final patchset.

Now, the intention of the mentioned patchset 2 was to render nodes
directly to the DOM in PageTreeDragHandler, instead of rendering to
a temporary element, just to export and re-import as HTML string
with jQuery/innerHTML.

Therefore PageTreeDragHandler is now refactored to a new,
(internal) method renderNodes() which allows the returned
nodes to be directly attached to the document.

Also, while at it, all other lit-helper methods are marked as
internal as well, as they are still subject to change:
 * `renderHTML()` is only needed when mixing traditional jQuery
   rendering and lit-html (same as for the new `renderNodes()`.)
 * The `icon()` method could likely be replaced by a custom
   <typo3-backend-icon> component
 * `lll()` is only of use for globally available language identifiers
   (which are added via inline JS)  So this is also likely to change
   when more backend modules start to use lit-html/LitElement.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 4

Review log 59

  1. Benjamin Franzke uploaded patch set 1 02/08/21, 13:57

  2. Benjamin Franzke wrote 02/08/21, 13:57

    Topic set to lit
  3. TYPO3com voted on patch set 1 V -1 02/08/21, 14:05 Completed build in 07m 43s on Mon, 8 Feb, 02:05 PM Test Summary: 5 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9352

  4. TYPO3com commented on patch set 1 02/08/21, 14:12 Completed build in 22m 38s on Mon, 8 Feb, 02:12 PM Test Summary: 2 of 32826 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9352

  5. TYPO3com voted on patch set 1 V +1 02/08/21, 14:21 Completed build in 07m 46s on Mon, 8 Feb, 02:21 PM Test Summary: 32585 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9354

  6. core-ci voted on patch set 1 V +1 02/08/21, 14:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/484

  7. Benni Mack voted on patch set 1 V +1 CR +1 02/08/21, 16:41

  8. Christian Kuhn voted on patch set 1 V +2 CR +2 02/08/21, 17:46

  9. Christian Kuhn merged patch set 2 02/08/21, 17:46