Review main Merged

67672[BUGFIX] Allow quoting in TypoScript's select for leftjoin & rightjoin

Georg Ringer CR +2 V +2 Easy +1 −1 updated 02/09/21, 23:19

Commit message

By fixing a typo, the field quoting also works for `leftjoin` and `rightjoin`.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Wouter Wolters +1
    • Richard Haeser +1
    • Ayke Halder +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Georg Ringer uploaded patch set 1 02/09/21, 09:05

  2. Georg Ringer commented on patch set 1 02/09/21, 09:10

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 02/09/21, 09:13 Completed build in 08m 33s on Tue, 9 Feb, 09:13 AM Test Summary: 32587 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9370

  4. core-ci voted on patch set 1 V +1 02/09/21, 09:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/508

  5. Wouter Wolters voted on patch set 1 CR +1 02/09/21, 09:47

  6. Benni Mack voted on patch set 1 CR +1 02/09/21, 10:35

  7. Markus Klein voted on patch set 1 V +1 CR +1 02/09/21, 12:42

  8. Ayke Halder voted on patch set 1 CR +1 02/09/21, 13:14

  9. Richard Haeser voted on patch set 1 CR +1 02/09/21, 13:21

  10. Benni Mack voted on patch set 1 V +2 CR +2 02/09/21, 22:09

  11. Benni Mack merged patch set 2 02/09/21, 23:19