67676[TASK] Blind smtp password value in mail preset of Install Tool
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Richard Haeser +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 1
Review log 1016
-
Georg Ringer uploaded patch set 1 02/09/21, 13:01
-
Georg Ringer commented on patch set 1 02/09/21, 13:01
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 02/09/21, 13:10 Completed build in 08m 56s on Tue, 9 Feb, 01:10 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9388
-
core-ci voted on patch set 1 V +1 02/09/21, 13:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/526
-
Richard Haeser commented on patch set 1 02/09/21, 13:16
Custom.html:22Should we also add autocomplete="new-password" as my browser now prefilled the fields. -
Georg Ringer commented on patch set 1 02/09/21, 13:27
Custom.html:22Replysure, feel free -
Richard Haeser uploaded patch set 2 02/09/21, 13:38
-
Richard Haeser uploaded patch set 3 02/09/21, 13:39
-
Richard Haeser commented on patch set 3 V +1 CR +1 02/09/21, 13:43
Custom.html:22ReplyDone -
TYPO3com voted on patch set 2 V +1 02/09/21, 13:46 Completed build in 08m 01s on Tue, 9 Feb, 01:46 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9392
-
TYPO3com voted on patch set 3 V +1 02/09/21, 13:48 Completed build in 09m 13s on Tue, 9 Feb, 01:48 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9393
-
core-ci voted on patch set 2 V +1 02/09/21, 13:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/530
-
Georg Ringer voted on patch set 3 V +1 CR +1 02/09/21, 13:50
-
core-ci voted on patch set 3 V +1 02/09/21, 13:53 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/531
-
Benjamin Franzke commented on patch set 3 V +2 CR +2 02/10/21, 09:34
Custom.html:22ReplyHm, I don't really like autocomplete="new-password" here, but we did it in https://review.typo3.org/c/Packages/TYPO3.CMS/+/61451 as well, so mehh… autocomplete="new-password" is not just a hint to prevent autofill, but also a hint for the browser to offer assistence for creating (and possibly storing) a new password: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#values autocomplete="off" instead of "new-password" works perfectly in chrome. (I guess they fixed the bug in the meantime). anyway, since is also intended for 10.4, we can migrate all these cases back to autcomplete=off once all browsers fix their bugs. -
Benjamin Franzke merged patch set 4 02/10/21, 09:34