Review main Merged

67677[TASK] Streamline Page Tree toolbar UX

Benni Mack CR +2 V +2 Normal +74 −161 updated 02/09/21, 21:20

Commit message

The PageTree toolbar now displays both menu
areas ("main menu" and "submenu") all the time
and removes the submenu toggles / buttons.

This is a request from various UX developers to:
* remove buttons for toggling if there is enough space
* decouple buttons from the click / drag functionality (some had borders, some did not)
* not hide the filter in a submenu (unclear that the left buttons are menu toggles)

In itself, the loading area is now clearer (via
simpler CSS), and the TypeScript/JS code gains
simplicity for building the menu.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Georg Ringer +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 8

Review log 711

  1. Benni Mack uploaded patch set 1 02/09/21, 13:36

  2. TYPO3com voted on patch set 1 V -1 02/09/21, 13:44 Completed build in 08m 07s on Tue, 9 Feb, 01:44 PM Test Summary: 3 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9391

  3. core-ci voted on patch set 1 V -1 02/09/21, 13:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/529

  4. Benni Mack uploaded patch set 2 02/09/21, 15:09

  5. TYPO3com voted on patch set 2 V +1 02/09/21, 15:16 Completed build in 06m 29s on Tue, 9 Feb, 03:16 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9401

  6. core-ci voted on patch set 2 V +1 02/09/21, 15:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/538

  7. Georg Ringer voted on patch set 2 V +1 CR +1 02/09/21, 19:12

  8. Richard Haeser voted on patch set 2 V +2 CR +2 02/09/21, 19:35

  9. Richard Haeser merged patch set 3 02/09/21, 19:35

  10. Benjamin Franzke commented on patch set 3 02/09/21, 19:42

    _svgtree.scss:305

    Once again I'm too late to the merge party, but the vertical alignment is not nice here. The searchbar overlaps to the left in contrast to the toolbar icons. The following settings margin: 0 .5rem 0 .25rem; would be much better here – was about to push that, but then it was already merged :(
  11. Benjamin Franzke commented on patch set 3 02/09/21, 19:52

    _svgtree.scss:305 Reply Unresolved