Review main Merged

67678[TASK] Inject cache into IconRegistry

Benjamin Franzke CR +2 V +2 Normal +39 −70 updated 02/25/21, 17:26

Commit message

This is to avoid calling IconRegistry::setCache during early bootstrap.
That hack was needed back when CacheManager was streamlined to
only be usable after ext_localconf has been loaded (#86353).
Since DI was not available back then, assets cache needed to injected
statically. Now that DI is available, we can inject withing the factory.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 6

Review log 1123

  1. Benjamin Franzke uploaded patch set 1 02/09/21, 18:28

  2. TYPO3com voted on patch set 1 V -1 02/09/21, 18:28 Completed build in 11s on Tue, 9 Feb, 06:28 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9407

  3. core-ci voted on patch set 1 V -1 02/09/21, 18:29 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/545

  4. Benjamin Franzke wrote 02/09/21, 19:14

    Topic set to di
  5. Benjamin Franzke uploaded patch set 2 02/09/21, 19:22

  6. TYPO3com voted on patch set 2 V +1 02/09/21, 19:30 Completed build in 07m 34s on Tue, 9 Feb, 07:30 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9408

  7. core-ci voted on patch set 2 V +1 02/09/21, 19:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/546

  8. Benjamin Franzke rebased onto patch set 3 02/10/21, 05:30

  9. TYPO3com voted on patch set 3 V +1 02/10/21, 05:41 Completed build in 11m 11s on Wed, 10 Feb, 05:41 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9429

  10. core-ci voted on patch set 3 V +1 02/10/21, 05:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/569

  11. Benjamin Franzke rebased onto patch set 4 02/19/21, 20:29

  12. TYPO3com voted on patch set 4 V +1 02/19/21, 20:42 Completed build in 12m 38s on Fri, 19 Feb, 08:42 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9643

  13. core-ci voted on patch set 4 V -1 02/19/21, 20:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/863

  14. Benni Mack rebased onto patch set 5 02/22/21, 14:15

  15. TYPO3com voted on patch set 5 V +1 02/22/21, 14:22 Completed build in 06m 40s on Mon, 22 Feb, 02:22 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9658

  16. core-ci voted on patch set 5 V +1 02/22/21, 14:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/887

  17. Christian Kuhn updated the commit message in patch set 6 02/25/21, 16:46

  18. TYPO3com voted on patch set 6 V +1 02/25/21, 16:54 Completed build in 07m 30s on Thu, 25 Feb, 04:54 PM Test Summary: 32708 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9729

  19. core-ci voted on patch set 6 V +1 02/25/21, 16:56 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1010

  20. Christian Kuhn voted on patch set 6 V +1 CR +1 02/25/21, 17:04

  21. Oli Bartsch voted on patch set 6 V +1 CR +1 02/25/21, 17:25

  22. Christian Kuhn voted on patch set 6 V +2 CR +2 02/25/21, 17:25

  23. Christian Kuhn merged patch set 7 02/25/21, 17:26