67679[TASK] Improve PageTree search input alignment
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Richard Haeser +1
-
Verified V +2 Done
- Benni Mack +2
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 2
Files 2
Review log 79
-
Benjamin Franzke uploaded patch set 1 02/09/21, 19:51
-
Richard Haeser commented on patch set 1 02/09/21, 19:56
Good catch. Is there a reason that the input field is just a couple of pixels more to the left than the icons? With a 0.35rem padding left, this seems to be exact. But maybe there is a reason? -
TYPO3com voted on patch set 1 V +1 02/09/21, 20:00 Completed build in 08m 52s on Tue, 9 Feb, 08:00 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9409
-
Richard Haeser commented on patch set 1 02/09/21, 20:02
Reply
I guess this depends on the icon that is shown as first icon. -
core-ci voted on patch set 1 V +1 02/09/21, 20:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/547
-
Richard Haeser voted on patch set 1 V +1 CR +1 02/09/21, 20:04
-
Benjamin Franzke commented on patch set 1 02/09/21, 20:30
Reply
Nah, all toolbar icons have 0.25rem padding, see .svg-toolbar__drag-node – this same offset is now added in here. -
Benni Mack voted on patch set 1 V +2 CR +2 02/09/21, 21:21
-
Benni Mack merged patch set 2 02/09/21, 21:21