Review main Merged

67680[TASK] Introduce ModuleStateStorage replacing fsMod

Oliver Hader CR +2 V +2 Hard +461 −162 updated 08/11/21, 20:51

Commit message

JavaScript object :js:`top.fsMod` managing the "state" for page-tree and
file-tree related contexts in the backend user-interface like this:

* `top.fsMod.recentIds.web` contained the current ("recent")
  page or file related identifier details were shown for
* `top.fsMod.navFrameHighlightedID.web` contained the currently
  selected identifier that was highlighted in page-tree or file-tree
* `top.fsMod.currentBank` contained the current mount point or
  file mount ("bank") used in page-tree or file-tree

To get rid of inline JavaScript and reduce usage of JavaScript `top.*`,
mentioned `top.fsMod` has been deprecated and replaced by new component
`ModuleStateStorage`. Reading data from `top.fsMod` is still possible
as a fall-back.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Wouter Wolters +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 41

Show 21 more files

Review log 3561

Show 2036 earlier messages
  1. Oliver Hader uploaded patch set 1 02/09/21, 20:21

  2. Oliver Hader marked it work in progress 02/09/21, 20:22

  3. TYPO3com voted on patch set 1 V -1 02/09/21, 20:30 Completed build in 08m 53s on Tue, 9 Feb, 08:30 PM Test Summary: 6 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9411

  4. core-ci voted on patch set 1 V -1 02/09/21, 20:39 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/549

  5. Oliver Hader uploaded patch set 2 04/06/21, 17:12

  6. TYPO3com voted on patch set 2 V +1 04/06/21, 17:18 Completed build in 06m 37s on Tue, 6 Apr, 05:18 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10505

  7. core-ci voted on patch set 2 V -1 04/06/21, 17:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2055

  8. Oliver Hader uploaded patch set 3 04/06/21, 17:44

  9. Oliver Hader voted on patch set 3 CR -1 04/06/21, 17:44

  10. TYPO3com voted on patch set 3 V +1 04/06/21, 17:51 Completed build in 06m 56s on Tue, 6 Apr, 05:51 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10507

  11. core-ci voted on patch set 3 V -1 04/06/21, 17:57 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2057

  12. Oliver Hader uploaded patch set 4 06/14/21, 12:25

  13. core-ci voted on patch set 4 V -1 06/14/21, 12:28 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12406

  14. Oliver Hader uploaded patch set 5 06/14/21, 12:29

  15. Oliver Hader commented on patch set 5 CR -1 06/14/21, 12:37

    Having two conflicting `ModuleState` objs now...
  16. core-ci voted on patch set 5 V -1 06/14/21, 12:42 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12407

  17. Oliver Hader uploaded patch set 6 06/14/21, 12:51

  18. Oliver Hader uploaded patch set 7 06/14/21, 12:57

  19. core-ci voted on patch set 6 V -1 06/14/21, 13:01 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12411

  20. core-ci voted on patch set 7 V -1 06/14/21, 13:09 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12412

  21. Oliver Hader uploaded patch set 8 06/14/21, 13:10

  22. Oliver Hader uploaded patch set 9 06/14/21, 13:17

  23. core-ci voted on patch set 8 V -1 06/14/21, 13:20 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12415

  24. core-ci voted on patch set 9 V -1 06/14/21, 13:26 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/12418

  25. Benni Mack uploaded patch set 10 08/06/21, 07:47

  26. core-ci voted on patch set 10 V -1 08/06/21, 08:02 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14187

  27. Oliver Hader uploaded patch set 11 08/09/21, 13:34

  28. Oliver Hader commented on patch set 11 08/09/21, 13:37

    This change is ready for review.
  29. core-ci voted on patch set 11 V -1 08/09/21, 14:09 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14332

  30. Oliver Hader uploaded patch set 12 08/09/21, 15:14

  31. Oliver Hader marked it work in progress 08/09/21, 15:15

  32. core-ci voted on patch set 12 V -1 08/09/21, 15:30 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14337

  33. Oliver Hader uploaded patch set 13 08/09/21, 15:48

  34. Oliver Hader commented on patch set 13 08/09/21, 16:01

    This change is ready for review.
  35. core-ci voted on patch set 13 V -1 08/09/21, 16:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14338

  36. Benni Mack uploaded patch set 14 08/09/21, 19:56

  1. core-ci voted on patch set 14 V -1 08/09/21, 20:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14403

  2. Benni Mack uploaded patch set 15 08/10/21, 13:31

  3. Christian Kuhn rebased onto patch set 16 08/10/21, 13:39

  4. core-ci voted on patch set 16 V -1 08/10/21, 14:06 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14485

  5. Benni Mack uploaded patch set 17 08/11/21, 10:15

  6. core-ci voted on patch set 17 V -1 08/11/21, 10:38 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14571

  7. Benni Mack uploaded patch set 18 08/11/21, 12:12

  8. Benni Mack uploaded patch set 19 08/11/21, 12:23

  9. core-ci voted on patch set 18 V -1 08/11/21, 12:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14584

  10. core-ci voted on patch set 19 V -1 08/11/21, 12:49 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14588

  11. Benni Mack uploaded patch set 20 08/11/21, 15:24

  12. core-ci voted on patch set 20 V -1 08/11/21, 15:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14609

  13. Benni Mack uploaded patch set 21 08/11/21, 16:07

  14. core-ci voted on patch set 21 V -1 08/11/21, 16:22 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14617

  15. Benni Mack uploaded patch set 22 08/11/21, 17:06

  16. core-ci voted on patch set 22 V -1 08/11/21, 17:20 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14620

  17. Benni Mack uploaded patch set 23 08/11/21, 18:46

  18. core-ci voted on patch set 23 V -1 08/11/21, 19:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14625

  19. Benni Mack uploaded patch set 24 08/11/21, 19:26

  20. core-ci voted on patch set 24 V +1 08/11/21, 19:38 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14628

  21. Benni Mack voted on patch set 24 V +1 CR +1 08/11/21, 19:42

  22. Oli Bartsch voted on patch set 24 V +1 CR +1 08/11/21, 19:53

  23. Wouter Wolters voted on patch set 24 CR +1 08/11/21, 20:13

  24. Benni Mack voted on patch set 24 V +2 CR +2 08/11/21, 20:51

  25. Benni Mack merged patch set 25 08/11/21, 20:51