67682[TASK] Rework Drag+Drop for SVG trees
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Oliver Hader +1
-
Verified V +2 Done
- Richard Haeser +2
- Oliver Hader +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 15
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SelectTree.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTree.ts+3 −101
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeDragDrop.ts4+485 −189
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeDragHandler.tsdeleted+0 −458
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/PageTree/PageTreeToolbar.ts+2 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/DragDrop.tsnew+251 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tree/TreeNode.ts+5 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SvgTree.ts+27 −26
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine/Element/SelectTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragDrop.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeDragHandler.jsdeleted+0 −23
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTreeToolbar.js+2 −2
- typo3/sysext/backend/Resources/Public/JavaScript/Tree/DragDrop.jsnew+23 −0
- typo3/sysext/backend/Resources/Public/JavaScript/SvgTree.js+1 −1
Review log 2042
Show 617 earlier messages
-
Benni Mack uploaded patch set 1 02/09/21, 21:00
-
Benni Mack uploaded patch set 2 02/09/21, 21:03
-
TYPO3com voted on patch set 1 V -1 02/09/21, 21:08 Completed build in 08m 20s on Tue, 9 Feb, 09:08 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9413
-
TYPO3com voted on patch set 2 V -1 02/09/21, 21:12 Completed build in 08m 37s on Tue, 9 Feb, 09:12 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9414
-
core-ci voted on patch set 1 V -1 02/09/21, 21:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/551
-
core-ci voted on patch set 2 V -1 02/09/21, 21:17 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/552
-
Oliver Hader uploaded patch set 3 02/09/21, 21:19
-
Benni Mack updated the commit message in patch set 4 02/09/21, 21:22
-
TYPO3com voted on patch set 3 V -1 02/09/21, 21:28 Completed build in 08m 40s on Tue, 9 Feb, 09:28 PM Test Summary: 80 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9416
-
core-ci voted on patch set 3 V -1 02/09/21, 21:29 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/554
-
TYPO3com voted on patch set 4 V -1 02/09/21, 21:31 Completed build in 09m 07s on Tue, 9 Feb, 09:31 PM Test Summary: 80 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9417
-
core-ci voted on patch set 4 V -1 02/09/21, 21:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/555
-
Benni Mack uploaded patch set 5 02/09/21, 21:40
-
TYPO3com commented on patch set 5 02/09/21, 21:47 Completed build in 07m 01s on Tue, 9 Feb, 09:47 PM Test Summary: 80 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9418
-
core-ci commented on patch set 5 02/09/21, 21:52 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/556
-
Benni Mack uploaded patch set 6 02/09/21, 22:08
-
TYPO3com voted on patch set 6 V +1 02/09/21, 22:17 Completed build in 09m 09s on Tue, 9 Feb, 10:17 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9420
-
core-ci voted on patch set 6 V +1 02/09/21, 22:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/558
-
Andreas Kienast uploaded patch set 7 02/10/21, 06:12
-
Andreas Kienast commented on patch set 7 CR +1 02/10/21, 06:14
While the patch work, I notices a performance degradation when dragging an element while the "Delete" box on the right hand side is visible. -
TYPO3com voted on patch set 7 V +1 02/10/21, 06:21 Completed build in 08m 30s on Wed, 10 Feb, 06:21 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9431
-
core-ci voted on patch set 7 V +1 02/10/21, 06:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/571
-
Richard Haeser commented on patch set 7 V +1 CR +1 02/10/21, 08:16
Reply
I can't verify that issue. Here it is still smooth -
Oliver Hader commented on patch set 7 CR -1 02/10/21, 08:17
PageTreeDragDrop.ts:78Do we want to change that to a proper type interface or keep it for BW-compatibility?PageTreeDragDrop.ts:287Where is this coming from or used in? -
Oliver Hader uploaded patch set 8 02/10/21, 09:25
-
TYPO3com voted on patch set 8 V +1 02/10/21, 09:34 Completed build in 08m 30s on Wed, 10 Feb, 09:34 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9433
-
Oliver Hader commented on patch set 8 02/10/21, 09:34
PageTreeDragDrop.ts:78ReplyDonePageTreeDragDrop.ts:287ReplyDone -
core-ci voted on patch set 8 V +1 02/10/21, 09:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/572
-
Oliver Hader voted on patch set 8 CR -1 02/10/21, 09:43
-
Oliver Hader uploaded patch set 9 02/10/21, 09:44
-
TYPO3com voted on patch set 9 V +1 02/10/21, 09:51 Completed build in 06m 11s on Wed, 10 Feb, 09:51 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9435
-
core-ci voted on patch set 9 V +1 02/10/21, 09:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/575
-
Benni Mack rebased onto patch set 10 02/10/21, 12:06
-
TYPO3com voted on patch set 10 V +1 02/10/21, 12:15 Completed build in 08m 41s on Wed, 10 Feb, 12:15 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9436
-
core-ci voted on patch set 10 V +1 02/10/21, 12:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/578
-
Oliver Hader uploaded patch set 11 02/10/21, 12:45
-
Oliver Hader voted on patch set 11 V +1 CR +1 02/10/21, 12:45
-
TYPO3com voted on patch set 11 V +1 02/10/21, 12:54 Completed build in 08m 37s on Wed, 10 Feb, 12:54 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9438
-
core-ci voted on patch set 11 V +1 02/10/21, 12:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/580
-
Richard Haeser voted on patch set 11 V +1 02/10/21, 15:05
-
Richard Haeser voted on patch set 11 V +2 CR +2 02/10/21, 15:13
-
Richard Haeser merged patch set 12 02/10/21, 15:13