Review main Merged

67682[TASK] Rework Drag+Drop for SVG trees

Benni Mack CR +2 V +2 Expert +803 −808 updated 02/10/21, 15:13

Commit message

This change splits up Drag+Drop handling in general
for SVG-based trees into PageTree specific logic, and
common usages. This makes Drag+Drop functionality
usable in more places than just the PageTree

In addition, all usages of jQuery are removed and
proper types were added instead of using "any".

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 15

Review log 2042

Show 617 earlier messages
  1. Benni Mack uploaded patch set 1 02/09/21, 21:00

  2. Benni Mack uploaded patch set 2 02/09/21, 21:03

  3. TYPO3com voted on patch set 1 V -1 02/09/21, 21:08 Completed build in 08m 20s on Tue, 9 Feb, 09:08 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9413

  4. TYPO3com voted on patch set 2 V -1 02/09/21, 21:12 Completed build in 08m 37s on Tue, 9 Feb, 09:12 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9414

  5. core-ci voted on patch set 1 V -1 02/09/21, 21:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/551

  6. core-ci voted on patch set 2 V -1 02/09/21, 21:17 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/552

  7. Oliver Hader uploaded patch set 3 02/09/21, 21:19

  8. Benni Mack updated the commit message in patch set 4 02/09/21, 21:22

  9. TYPO3com voted on patch set 3 V -1 02/09/21, 21:28 Completed build in 08m 40s on Tue, 9 Feb, 09:28 PM Test Summary: 80 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9416

  10. core-ci voted on patch set 3 V -1 02/09/21, 21:29 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/554

  11. TYPO3com voted on patch set 4 V -1 02/09/21, 21:31 Completed build in 09m 07s on Tue, 9 Feb, 09:31 PM Test Summary: 80 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9417

  12. core-ci voted on patch set 4 V -1 02/09/21, 21:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/555

  13. Benni Mack uploaded patch set 5 02/09/21, 21:40

  14. TYPO3com commented on patch set 5 02/09/21, 21:47 Completed build in 07m 01s on Tue, 9 Feb, 09:47 PM Test Summary: 80 of 32838 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9418

  15. core-ci commented on patch set 5 02/09/21, 21:52 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/556

  16. Benni Mack uploaded patch set 6 02/09/21, 22:08

  17. TYPO3com voted on patch set 6 V +1 02/09/21, 22:17 Completed build in 09m 09s on Tue, 9 Feb, 10:17 PM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9420

  1. core-ci voted on patch set 6 V +1 02/09/21, 22:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/558

  2. Andreas Kienast uploaded patch set 7 02/10/21, 06:12

  3. Andreas Kienast commented on patch set 7 CR +1 02/10/21, 06:14

    While the patch work, I notices a performance degradation when dragging an element while the "Delete" box on the right hand side is visible.
  4. TYPO3com voted on patch set 7 V +1 02/10/21, 06:21 Completed build in 08m 30s on Wed, 10 Feb, 06:21 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9431

  5. core-ci voted on patch set 7 V +1 02/10/21, 06:22 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/571

  6. Richard Haeser commented on patch set 7 V +1 CR +1 02/10/21, 08:16

    Reply

    I can't verify that issue. Here it is still smooth
  7. Oliver Hader commented on patch set 7 CR -1 02/10/21, 08:17

    PageTreeDragDrop.ts:78

    Do we want to change that to a proper type interface or keep it for BW-compatibility?

    PageTreeDragDrop.ts:287

    Where is this coming from or used in?
  8. Oliver Hader uploaded patch set 8 02/10/21, 09:25

  9. TYPO3com voted on patch set 8 V +1 02/10/21, 09:34 Completed build in 08m 30s on Wed, 10 Feb, 09:34 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9433

  10. Oliver Hader commented on patch set 8 02/10/21, 09:34

    PageTreeDragDrop.ts:78 Reply

    Done

    PageTreeDragDrop.ts:287 Reply

    Done
  11. core-ci voted on patch set 8 V +1 02/10/21, 09:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/572

  12. Oliver Hader voted on patch set 8 CR -1 02/10/21, 09:43

  13. Oliver Hader uploaded patch set 9 02/10/21, 09:44

  14. TYPO3com voted on patch set 9 V +1 02/10/21, 09:51 Completed build in 06m 11s on Wed, 10 Feb, 09:51 AM Test Summary: 32597 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9435

  15. core-ci voted on patch set 9 V +1 02/10/21, 09:55 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/575

  16. Benni Mack rebased onto patch set 10 02/10/21, 12:06

  17. TYPO3com voted on patch set 10 V +1 02/10/21, 12:15 Completed build in 08m 41s on Wed, 10 Feb, 12:15 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9436

  18. core-ci voted on patch set 10 V +1 02/10/21, 12:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/578

  19. Oliver Hader uploaded patch set 11 02/10/21, 12:45

  20. Oliver Hader voted on patch set 11 V +1 CR +1 02/10/21, 12:45

  21. TYPO3com voted on patch set 11 V +1 02/10/21, 12:54 Completed build in 08m 37s on Wed, 10 Feb, 12:54 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9438

  22. core-ci voted on patch set 11 V +1 02/10/21, 12:57 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/580

  23. Richard Haeser voted on patch set 11 V +1 02/10/21, 15:05

  24. Richard Haeser voted on patch set 11 V +2 CR +2 02/10/21, 15:13

  25. Richard Haeser merged patch set 12 02/10/21, 15:13