Review main Merged

67683[TASK] Clean up SvgTree code

Benni Mack CR +2 V +2 Hard +265 −357 updated 02/10/21, 19:38

Commit message

Now that jQuery has gone and TypeScript is in place for Tree components,
the next step is to consolidate and sort out re-usability.

This change prepares the way for allowing multiple trees in the
navigation component area (for FileStorageTree).

* ContextMenu allows int+number (which is correct)
* ContextMenu has all information from the TreeNode (and not the SVG
  element) - less Markup!
* KeyTypeEnums are used throughout SvgTree
* Centralized place for error notifications, removing duplicate code
* tree.settings.isDragAnDrop is removed in favor of
  tree.settings.allowDragMove (which already exists)
* Unused properties in TreeNode are removed
* Since we are now in "TS module land", PageTreeToolbar.ts is removed
  because the class is only used in the PageTreeElement, so it does
  not need to be exposed anymore.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oliver Hader +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 14

Review log 610

  1. Benni Mack uploaded patch set 1 02/10/21, 16:00

  2. TYPO3com voted on patch set 1 V +1 02/10/21, 16:08 Completed build in 08m 11s on Wed, 10 Feb, 04:08 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9442

  3. core-ci voted on patch set 1 V +1 02/10/21, 16:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/590

  4. Richard Haeser voted on patch set 1 V +1 CR +1 02/10/21, 16:27

  5. Oliver Hader uploaded patch set 2 02/10/21, 19:11

  6. Oliver Hader voted on patch set 2 V +1 CR +1 02/10/21, 19:16

  7. TYPO3com voted on patch set 2 V +1 02/10/21, 19:19 Completed build in 07m 54s on Wed, 10 Feb, 07:19 PM Test Summary: 32600 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9447

  8. core-ci voted on patch set 2 V +1 02/10/21, 19:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/604

  9. Richard Haeser voted on patch set 2 V +2 CR +2 02/10/21, 19:38

  10. Richard Haeser merged patch set 3 02/10/21, 19:38