Review main Merged

67687[FEATURE] Use SVG Trees in Record Selector

Benni Mack CR +2 V +2 Expert +1190 −456 updated 04/16/21, 11:35

Commit message

This change adds the SVG-based page tree in the
record selector and the Page Link picker, replacing
decade-old clumsy HTML code for generating trees.

This replacement not only unifies the user experience
across the navigation trees and the Element
Browser / Link Pickers making the whole look + feel
very consistent.

It also allows to finally use all the features built
in the SVG trees:

* A filter across the tree built on the browser and automatic
  refreshing
* collapse + expand and post-loading is now built with the
  same AJAX endpoints as the navigation components, making
  the general loading much faster
* Temporary Mount Points now look exactly the same as in the
  navigation area.
* Keyboard navigation
* The Content Area inside the Record Selector and the Link
  Pickers is replaced via AJAX calls

Especially the last feature makes it a breeze to use
the new trees to select items much faster.

All existing features, such as directly selecting a page
or link to a page within the tree is added as so-called
SVG-tree "actions" in the right corner when hovering,
avoiding the additional "play" icon in the tree.

Custom support for Element Browser "mount points" is also
kept and included.

The SVG tree is added to the following components:

* Database Browser / Record Selector (e.g. choosing storagePid in plugins)
* File Browser / Record Selector (e.g. selecting an image in the plugin)
* Folder Browser / Record Selector
* Link Picker for Pages / Content Elements ("link to a page")
* Link Picker for Files ("link to a file")
* Link Picker for Folders ("link to a folder")
* Link Picker for Records (e.g. news record)

All link picker functionality is available for typolink fields (e.g. tt_content.header_link)
and when linking inside the Rich Text Editor.

Some technical details under-the-hood:
* The trees are now built as SVG tree / LIT elements
* All Element Browser / Link Picker trees are named "Browsable...Tree"
* The AJAX endpoints for fetching data are used
* The Page Tree now uses a different configuration URL with a "?readonly=1" parameter, with the main difference to initialize EB mountpoints instead
* Within the tree: The SVG tree actions is a separate container for elements on the right-hand of the tree
* The GET parameter "contentOnly" represents to only load parts of the HTML (the content area) when fetching from AJAX

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Jonas Eberle +1
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 47

Show 27 more files

Review log 85188

Show 64163 earlier messages
  1. Benni Mack uploaded patch set 1 02/10/21, 21:27

  2. TYPO3com voted on patch set 1 V -1 02/10/21, 21:35 Completed build in 08m 15s on Wed, 10 Feb, 09:35 PM Test Summary: 4 of 32841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9451

  3. core-ci voted on patch set 1 V -1 02/10/21, 21:39 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/613

  4. Tymoteusz Motylewski commented on patch set 1 02/23/21, 23:23

    if this tree is not using most of the page tree component features maybe it should inherit from svgtree as category tree does?(no drag-drop or inline wditing then)
  5. Benni Mack commented on patch set 1 02/24/21, 08:41

    Reply

    yes. this PoC shows the limitation of the abstraction we currently have. IMHO we'd either a) extract the action functionality (DragDrop, most of it done already, In-Place-Editing) into a separate logic b) Have an "EditablePageTree" e.g., that contains the features, but have PageTree for the ElementBrowser / Link Picker. The rest of the main distinction between the non-editable PageTree + SvgTree is currently a) filtering on the server side b) loading per sub-level on the server side c) keeping navigation-component state (should not be part of that component anyways, but solved via events) d) different "click" behavior (should also be extendable via hooks) e) custom rendering functionality for stop-pagetree f) temporary mount point (should be moved to the PageTree navigation component) g) custom itemStateIdentifier (see TreeNode, we should have a PageTreeNode extended from the TreeNode) h) context menu
  6. Benni Mack uploaded patch set 2 03/07/21, 00:19

  7. TYPO3com voted on patch set 2 V -1 03/07/21, 00:20 Completed build in 22s on Sun, 7 Mar, 12:20 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9893

  8. core-ci voted on patch set 2 V -1 03/07/21, 00:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1232

  9. Benni Mack uploaded patch set 3 03/09/21, 14:13

  10. TYPO3com voted on patch set 3 V -1 03/09/21, 14:13 Completed build in 20s on Tue, 9 Mar, 02:13 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9970

  11. core-ci voted on patch set 3 V -1 03/09/21, 14:31 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1324

  12. Benni Mack uploaded patch set 4 03/09/21, 15:18

  13. TYPO3com voted on patch set 4 V +1 03/09/21, 15:24 Completed build in 05m 42s on Tue, 9 Mar, 03:24 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9976

  14. core-ci voted on patch set 4 V -1 03/09/21, 15:27 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1331

  15. Benni Mack uploaded patch set 5 03/09/21, 16:36

  16. TYPO3com voted on patch set 5 V +1 03/09/21, 16:49 Completed build in 09m 15s on Tue, 9 Mar, 04:49 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9982

  17. core-ci voted on patch set 5 V -1 03/09/21, 16:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1337

  18. Benni Mack uploaded patch set 6 03/09/21, 16:59

  19. TYPO3com voted on patch set 6 V +1 03/09/21, 17:07 Completed build in 07m 33s on Tue, 9 Mar, 05:07 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9983

  20. core-ci voted on patch set 6 V -1 03/09/21, 17:09 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1338

  21. Benni Mack uploaded patch set 7 03/10/21, 14:22

  22. TYPO3com voted on patch set 7 V -1 03/10/21, 14:22 Completed build in 21s on Wed, 10 Mar, 02:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10016

  23. core-ci voted on patch set 7 V -1 03/10/21, 14:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1374

  24. Benni Mack uploaded patch set 8 03/11/21, 10:44

  25. TYPO3com voted on patch set 8 V +1 03/11/21, 10:54 Completed build in 09m 09s on Thu, 11 Mar, 10:54 AM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10049

  26. core-ci voted on patch set 8 V -1 03/11/21, 10:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1413

  27. Benni Mack uploaded patch set 9 03/12/21, 12:49

  28. TYPO3com voted on patch set 9 V -1 03/12/21, 12:50 Completed build in 22s on Fri, 12 Mar, 12:50 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10079

  29. core-ci voted on patch set 9 V -1 03/12/21, 13:22 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1457

  30. Benni Mack uploaded patch set 10 03/15/21, 08:58

  31. TYPO3com voted on patch set 10 V -1 03/15/21, 08:59 Completed build in 20s on Mon, 15 Mar, 08:59 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10134

  32. core-ci voted on patch set 10 V -1 03/15/21, 09:16 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1546

  33. Benni Mack uploaded patch set 11 03/15/21, 09:46

  34. TYPO3com voted on patch set 11 V +1 03/15/21, 09:53 Completed build in 06m 53s on Mon, 15 Mar, 09:53 AM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10136

  35. core-ci voted on patch set 11 V -1 03/15/21, 09:58 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1549

  36. Benni Mack uploaded patch set 12 03/16/21, 15:14

  37. TYPO3com voted on patch set 12 V -1 03/16/21, 15:15 Completed build in 53s on Tue, 16 Mar, 03:15 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10168

  38. core-ci voted on patch set 12 V -1 03/16/21, 15:26 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1606

  39. Benni Mack uploaded patch set 13 03/19/21, 11:02

  40. TYPO3com voted on patch set 13 V -1 03/19/21, 11:02 Completed build in 16s on Fri, 19 Mar, 11:02 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10231

  41. core-ci voted on patch set 13 V -1 03/19/21, 11:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1689

  42. Benni Mack uploaded patch set 14 03/19/21, 15:35

  43. TYPO3com voted on patch set 14 V +1 03/19/21, 15:42 Completed build in 07m 11s on Fri, 19 Mar, 03:42 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10236

  44. core-ci voted on patch set 14 V -1 03/19/21, 15:46 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1694

  45. Benni Mack uploaded patch set 15 03/19/21, 16:17

  46. TYPO3com voted on patch set 15 V +1 03/19/21, 16:22 Completed build in 05m 38s on Fri, 19 Mar, 04:22 PM Test Summary: 32907 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10240

  47. core-ci voted on patch set 15 V -1 03/19/21, 16:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1698

  48. Benni Mack rebased onto patch set 16 03/23/21, 09:28

  49. TYPO3com voted on patch set 16 V +1 03/23/21, 09:37 Completed build in 08m 55s on Tue, 23 Mar, 09:37 AM Test Summary: 32910 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10308

  50. core-ci voted on patch set 16 V -1 03/23/21, 09:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1784

  51. Benni Mack uploaded patch set 17 04/01/21, 10:34

  52. TYPO3com voted on patch set 17 V +1 04/01/21, 10:41 Completed build in 06m 38s on Thu, 1 Apr, 10:41 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10436

  53. core-ci voted on patch set 17 V -1 04/01/21, 10:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1965

  54. Benni Mack uploaded patch set 18 04/01/21, 12:36

  55. TYPO3com voted on patch set 18 V +1 04/01/21, 12:43 Completed build in 06m 59s on Thu, 1 Apr, 12:43 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10442

  56. Benni Mack uploaded patch set 19 04/01/21, 21:01

  57. TYPO3com voted on patch set 19 V +1 04/01/21, 21:08 Completed build in 07m 17s on Thu, 1 Apr, 09:08 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10451

  58. core-ci voted on patch set 19 V -1 04/01/21, 21:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1982

  59. Benni Mack uploaded patch set 20 04/01/21, 21:57

  60. TYPO3com voted on patch set 20 V +1 04/01/21, 22:05 Completed build in 07m 34s on Thu, 1 Apr, 10:05 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10453

  61. core-ci voted on patch set 20 V -1 04/01/21, 22:08 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1984

  62. Benni Mack uploaded patch set 21 04/01/21, 22:42

  63. Benni Mack uploaded patch set 22 04/01/21, 22:48

  64. TYPO3com voted on patch set 21 V +1 04/01/21, 22:49 Completed build in 07m 02s on Thu, 1 Apr, 10:49 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10454

  65. core-ci voted on patch set 21 V -1 04/01/21, 22:54 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1985

  66. TYPO3com voted on patch set 22 V +1 04/01/21, 22:56 Completed build in 07m 28s on Thu, 1 Apr, 10:56 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10455

  67. core-ci voted on patch set 22 V -1 04/01/21, 22:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1986

  68. Benni Mack uploaded patch set 23 04/02/21, 19:10

  69. TYPO3com voted on patch set 23 V -1 04/02/21, 19:10 Completed build in 20s on Fri, 2 Apr, 07:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10469

  70. Benni Mack uploaded patch set 24 04/02/21, 19:21

  71. TYPO3com voted on patch set 24 V -1 04/02/21, 19:21 Completed build in 19s on Fri, 2 Apr, 07:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10471

  72. core-ci voted on patch set 23 V -1 04/02/21, 19:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2003

  73. core-ci voted on patch set 24 V -1 04/02/21, 19:37 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2005

  74. Benni Mack uploaded patch set 25 04/05/21, 21:03

  75. TYPO3com voted on patch set 25 V -1 04/05/21, 21:04 Completed build in 22s on Mon, 5 Apr, 09:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10483

  76. core-ci voted on patch set 25 V -1 04/05/21, 21:19 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2030

  77. Benni Mack uploaded patch set 26 04/06/21, 15:31

  78. TYPO3com voted on patch set 26 V -1 04/06/21, 15:31 Completed build in 16s on Tue, 6 Apr, 03:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10496

  79. core-ci voted on patch set 26 V -1 04/06/21, 15:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2045

  80. Benni Mack uploaded patch set 27 04/06/21, 16:03

  81. TYPO3com voted on patch set 27 V -1 04/06/21, 16:03 Completed build in 18s on Tue, 6 Apr, 04:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10502

  82. core-ci voted on patch set 27 V -1 04/06/21, 16:14 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2051

  83. Benni Mack uploaded patch set 28 04/06/21, 16:27

  84. TYPO3com voted on patch set 28 V -1 04/06/21, 16:27 Completed build in 18s on Tue, 6 Apr, 04:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10504

  85. core-ci voted on patch set 28 V +1 04/06/21, 16:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2053

  86. Benni Mack uploaded patch set 29 04/08/21, 10:25

  87. TYPO3com voted on patch set 29 V -1 04/08/21, 10:25 Completed build in 18s on Thu, 8 Apr, 10:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10542

  88. core-ci voted on patch set 29 V +1 04/08/21, 10:38 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2102

  89. Benni Mack uploaded patch set 30 04/08/21, 11:55

  90. TYPO3com voted on patch set 30 V -1 04/08/21, 11:56 Completed build in 23s on Thu, 8 Apr, 11:56 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10550

  91. core-ci voted on patch set 30 V +1 04/08/21, 12:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2111

  92. Benni Mack uploaded patch set 31 04/08/21, 22:37

  93. TYPO3com voted on patch set 31 V -1 04/08/21, 22:38 Completed build in 18s on Thu, 8 Apr, 10:38 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10563

  94. core-ci voted on patch set 31 V -1 04/08/21, 22:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2124

  95. Benni Mack uploaded patch set 32 04/08/21, 22:52

  96. TYPO3com voted on patch set 32 V -1 04/08/21, 22:53 Completed build in 17s on Thu, 8 Apr, 10:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10565

  97. core-ci voted on patch set 32 V -1 04/08/21, 22:56 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2126

  98. Benni Mack uploaded patch set 33 04/08/21, 23:31

  99. TYPO3com voted on patch set 33 V -1 04/08/21, 23:38 Completed build in 07m 09s on Thu, 8 Apr, 11:38 PM Test Summary: 846 of 33503 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10566

  100. core-ci voted on patch set 33 V -1 04/08/21, 23:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2127

  101. Benni Mack uploaded patch set 34 04/09/21, 14:37

  102. TYPO3com voted on patch set 34 V -1 04/09/21, 14:37 Completed build in 19s on Fri, 9 Apr, 02:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10577

  103. core-ci voted on patch set 34 V -1 04/09/21, 14:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2143

  104. Benni Mack uploaded patch set 35 04/09/21, 20:40

  105. TYPO3com voted on patch set 35 V -1 04/09/21, 20:40 Completed build in 16s on Fri, 9 Apr, 08:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10587

  106. core-ci voted on patch set 35 V -1 04/09/21, 20:58 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2154

  107. Benni Mack uploaded patch set 36 04/09/21, 21:11

  108. TYPO3com voted on patch set 36 V +1 04/09/21, 21:17 Completed build in 06m 06s on Fri, 9 Apr, 09:17 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10591

  109. core-ci voted on patch set 36 V -1 04/09/21, 21:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2158

  110. Benni Mack uploaded patch set 37 04/09/21, 21:35

  111. TYPO3com voted on patch set 37 V +1 04/09/21, 21:41 Completed build in 06m 08s on Fri, 9 Apr, 09:41 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10592

  112. core-ci voted on patch set 37 V -1 04/09/21, 21:46 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2159

  113. Benni Mack uploaded patch set 38 04/09/21, 22:34

  114. TYPO3com voted on patch set 38 V +1 04/09/21, 22:42 Completed build in 07m 22s on Fri, 9 Apr, 10:42 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10596

  115. core-ci voted on patch set 38 V -1 04/09/21, 22:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2163

  116. Benni Mack uploaded patch set 39 04/09/21, 22:53

  117. TYPO3com voted on patch set 39 V +1 04/09/21, 23:00 Completed build in 07m 14s on Fri, 9 Apr, 11:00 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10597

  118. core-ci voted on patch set 39 V -1 04/09/21, 23:03 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2164

  119. Richard Haeser commented on patch set 39 04/12/21, 09:47

    When trying to set a link to a page and not use the link icon, but just click on the title (as the behaviour was before), it is kind of unclear how to link to that page. Maybe a button or something like that should be added to the "content window" to make it easier to link to the page you selected.
  120. Benni Mack uploaded patch set 40 04/12/21, 17:32

  121. Benni Mack commented on patch set 40 04/12/21, 17:33

    Reply

    done.
  122. TYPO3com voted on patch set 40 V +1 04/12/21, 17:40 Completed build in 07m 36s on Mon, 12 Apr, 05:40 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10623

  123. core-ci voted on patch set 40 V -1 04/12/21, 17:47 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2201

  124. Benni Mack uploaded patch set 41 04/12/21, 20:36

  125. TYPO3com voted on patch set 41 V +1 04/12/21, 20:45 Completed build in 09m 11s on Mon, 12 Apr, 08:45 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10629

  126. core-ci voted on patch set 41 V -1 04/12/21, 20:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2207

  127. Benni Mack updated the commit message in patch set 42 04/13/21, 06:14

  128. TYPO3com voted on patch set 42 V +1 04/13/21, 06:21 Completed build in 06m 52s on Tue, 13 Apr, 06:21 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10636

  129. core-ci voted on patch set 42 V -1 04/13/21, 06:25 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2217

  130. Oli Bartsch commented on patch set 42 04/13/21, 09:08

    TreeController.php:140 Unresolved

    Should we check for is_array here, too? Otherwise array_filter could lead to a TypeError.

    ElementBrowser.html:32

    Is this for future markup being rendered before/after? - Just wondering why we need sections for a single div container.
  131. Richard Haeser commented on patch set 42 04/13/21, 09:10

    Working on failing acceptance test and bug with refreshing a closed root
  132. Benni Mack commented on patch set 42 04/13/21, 11:13

    ElementBrowser.html:32 Reply

    RecordSelector (currently) needs the div wrapper, the Link Picker doesn't.
  133. Richard Haeser uploaded patch set 43 04/13/21, 11:24

  134. TYPO3com voted on patch set 43 V -1 04/13/21, 11:33 Completed build in 08m 24s on Tue, 13 Apr, 11:33 AM Test Summary: 32878 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10641

  135. Oli Bartsch commented on patch set 43 04/13/21, 11:40

    ElementBrowser.html:32 Reply

    Ack
  136. core-ci voted on patch set 43 V -1 04/13/21, 11:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2224

  137. Benni Mack uploaded patch set 44 04/13/21, 12:23

  138. Benni Mack uploaded patch set 45 04/13/21, 12:27

  139. TYPO3com voted on patch set 44 V +1 04/13/21, 12:31 Completed build in 08m 00s on Tue, 13 Apr, 12:31 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10643

  140. TYPO3com voted on patch set 45 V +1 04/13/21, 12:34 Completed build in 07m 03s on Tue, 13 Apr, 12:34 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10644

  141. core-ci voted on patch set 44 V -1 04/13/21, 12:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2226

  142. core-ci voted on patch set 45 V -1 04/13/21, 12:40 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2227

  143. Benni Mack uploaded patch set 46 04/13/21, 14:24

  144. TYPO3com voted on patch set 46 V +1 04/13/21, 14:31 Completed build in 06m 48s on Tue, 13 Apr, 02:31 PM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10648

  145. core-ci voted on patch set 46 V -1 04/13/21, 14:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2230

  146. Benni Mack uploaded patch set 47 04/14/21, 08:00

  147. TYPO3com voted on patch set 47 V +1 04/14/21, 08:06 Completed build in 06m 30s on Wed, 14 Apr, 08:06 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10654

  148. core-ci voted on patch set 47 V -1 04/14/21, 08:11 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2239

  149. Benni Mack uploaded patch set 48 04/14/21, 08:14

  150. TYPO3com voted on patch set 48 V +1 04/14/21, 08:20 Completed build in 06m 49s on Wed, 14 Apr, 08:20 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10655

  151. core-ci voted on patch set 48 V +1 04/14/21, 08:24 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2240

  152. Benni Mack uploaded patch set 49 04/14/21, 09:14

  153. TYPO3com voted on patch set 49 V +1 04/14/21, 09:21 Completed build in 07m 09s on Wed, 14 Apr, 09:21 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10656

  154. core-ci voted on patch set 49 V +1 04/14/21, 09:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2241

  155. Benni Mack uploaded patch set 50 04/14/21, 09:35

  156. TYPO3com voted on patch set 50 V +1 04/14/21, 09:42 Completed build in 06m 58s on Wed, 14 Apr, 09:42 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10657

  157. core-ci voted on patch set 50 V +1 04/14/21, 09:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2242

  158. Mathias Brodala commented on patch set 50 V +1 04/14/21, 10:03

    Just pure awesomeness, thanks a lot!
  159. Jonas Eberle commented on patch set 50 V +1 04/14/21, 10:34

    Feels really slick and that common look everywhere is wonderful. I couldn't produce any errors that are related to this change.
  160. Richard Haeser commented on patch set 50 V +1 CR +1 04/14/21, 11:24

    What an awesome job! Thanks a lot!
  161. Oli Bartsch voted on patch set 50 V +1 CR +1 04/14/21, 12:33

  162. Daniel Goerz voted on patch set 50 V +1 04/14/21, 14:18

  163. Markus Klein commented on patch set 50 CR +1 04/14/21, 16:37

    Not a real in depth review, that would take hours. But a look-through looks very good.
  1. Michael Schams commented on patch set 50 04/14/21, 18:07

    It's brilliant. I love it. I don't dare to down-vote :-) However, I discovered two issues with Firefox 83.0 Record Selector: two scroll bars in Firefox: https://forge.typo3.org/issues/93922 Record Selector: black area instead if icons in Firefox: https://forge.typo3.org/issues/93923
  2. Benni Mack commented on patch set 50 04/14/21, 19:26

    Reply

    I tested this in Firefox as well (both issues) and could not reproduce. I suggest to get this main patch in and look at this issue separately then, if that's OK with you?
  3. Benjamin Franzke commented on patch set 50 CR -1 04/15/21, 04:49

    Reply

    I also still experience scrolling issues. IMO we should tackle them before merging.

    _elementbrowser.scss:52

    We need to drop this 100vh statement from .element-browser. This statement makes .element-browser too small for it's content. Visually you don't see this, but while scrolling down, this causes the top (tab-bar) and the link-browser-title to scroll away (due to position: sticky).

    _elementbrowser.scss:124

    Just 100vh here, calc is unneeded.

    _elementbrowser.scss:128

    The tabpar is 44px in height. The link-browser-title is 42px. Therefore we'd need 100vh - 44px here. (Below it's correct: 86 = 44 + 42)

    BrowsableFileStorageTree.ts:120

    The name implies that the pagetree is reloaded, but it's redrawn. Maybe call this `triggerRender`? (I'm inclined to somehow hook this to lit's requestUpdate() method, but better not to fiddle with that right now).

    BrowsablePageTree.ts:28

    This is confusing, we got two components with only one dash difference in naming: * typo3-backend-component-browser-pagetree * typo3-backend-component-browser-page-tree in this module. Let's take better separated names, maybe: * typo3-backend-component-page-browser and * typo3-backend-component-page-browser-tree

    BrowsablePageTree.ts:129

    BrowsablePageTreeContainer
  4. Benjamin Franzke uploaded patch set 51 04/15/21, 04:51

  5. Benjamin Franzke commented on patch set 51 04/15/21, 04:51

    Reply

    @Michale: Please test with patchset 51, rearrenged some css. I do not encounter scrolling issues right now.

    _elementbrowser.scss:52 Reply

    Done

    _elementbrowser.scss:124 Reply

    Done

    _elementbrowser.scss:128 Reply

    Done
  6. TYPO3com voted on patch set 51 V +1 04/15/21, 04:58 Completed build in 07m 01s on Thu, 15 Apr, 04:58 AM Test Summary: 33267 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10668

  7. core-ci voted on patch set 51 V +1 04/15/21, 05:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2256

  8. Benni Mack voted on patch set 51 V +1 CR +1 04/15/21, 10:58

  9. Daniel Goerz voted on patch set 51 V +1 04/15/21, 11:15

  10. Oli Bartsch voted on patch set 51 V +1 CR +1 04/15/21, 11:19

  11. Richard Haeser commented on patch set 51 04/15/21, 11:19

    There are some unresolved comments by Benjamin.
  12. Richard Haeser commented on patch set 51 CR -1 04/15/21, 11:21

    Benni is on it
  13. Benni Mack commented on patch set 51 CR -2 04/15/21, 11:45

    @bnf, will take care of your suggestions first.
  14. Michael Schams commented on patch set 51 V +1 04/15/21, 14:11

    Reply

    Perfect! 👍 Both issues solved with patch set 51. Thanks Benjamin.
  15. Benni Mack uploaded patch set 52 04/16/21, 08:48

  16. Benni Mack commented on patch set 52 CR 0 04/16/21, 08:49

    BrowsableFileStorageTree.ts:120 Reply

    done.

    BrowsablePageTree.ts:28 Reply

    done.

    BrowsablePageTree.ts:129 Reply

    done.
  17. TYPO3com voted on patch set 52 V +1 04/16/21, 08:55 Completed build in 06m 59s on Fri, 16 Apr, 08:55 AM Test Summary: 33269 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10682

  18. core-ci voted on patch set 52 V +1 04/16/21, 08:59 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/2277

  19. Richard Haeser voted on patch set 52 V +1 CR +1 04/16/21, 09:12

  20. Jonas Eberle voted on patch set 52 V +1 04/16/21, 09:44

  21. Oli Bartsch voted on patch set 52 V +1 CR +1 04/16/21, 11:08

  22. Daniel Goerz voted on patch set 52 V +1 04/16/21, 11:16

  23. Benjamin Franzke voted on patch set 52 CR +1 04/16/21, 11:31

  24. Benjamin Franzke voted on patch set 52 V +2 CR +2 04/16/21, 11:33

  25. Benjamin Franzke merged patch set 53 04/16/21, 11:35