Review main Merged

67688[TASK] Update Bootstrap to 5.0.0-beta2

Benni Mack CR +2 V +2 Easy +11 −11 updated 02/12/21, 20:15

Commit message

This beta fixes various issues related to positioning of tooltips
and popovers.

See https://blog.getbootstrap.com/2021/02/10/bootstrap-5-beta-2/

Commands used:
> yarn upgrade bootstrap@^5.0.0-beta2
> grunt build

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 1519

  1. Benni Mack uploaded patch set 1 02/11/21, 11:57

  2. TYPO3com voted on patch set 1 V +1 02/11/21, 12:06 Completed build in 08m 32s on Thu, 11 Feb, 12:05 PM Test Summary: 32599 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9457

  3. core-ci voted on patch set 1 V +1 02/11/21, 12:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/633

  4. Andreas Kienast voted on patch set 1 CR +1 02/11/21, 12:17

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 02/11/21, 13:34

  6. Benjamin Franzke commented on patch set 1 V -1 02/11/21, 14:16

    the dropdown-menu in scaffold-toolbar now has 2px offset to the toolbar (e.g. opendocs or help).
  7. Richard Haeser commented on patch set 1 V +1 CR +1 02/11/21, 14:18

    Although this update makes the position of popovers worse, (click on the ? icon in the page module) I guess it is ok to merge this to keep up to date with the bootstrap 5 releases.
  8. Richard Haeser commented on patch set 1 V 0 CR 0 02/11/21, 14:19

    Reply

    Ah good catch!
  9. Christian Kuhn voted on patch set 1 V 0 CR 0 02/11/21, 14:25

  10. Benjamin Franzke commented on patch set 1 02/11/21, 14:30

    Reply

    good catch. This really looks like a bs5-beta2 bug, as the popover is placed with a `right` position via inline style, while `left: 0;` is set via bootstrap stylesheet. That means their positioning code would also need to set `left:auto` for that to work. Hm.. unsure whether we want to merge this. But clearly it would be good for us to discover all beta2 bugs, in order to have a better beta3..
  11. Benni Mack commented on patch set 1 02/11/21, 19:26

    @bnf I suggest we fix the mentioned issue in the topbar modules, and then go for it. I can also afterwards identify the issue with the beta-2 and report it to beta-3, but hey, that's beta-life. right? I'd rather have the beta2 now and see what else this one might solve (I do have a dropdown+responsive patch still lying around, maybe we can also help fix this in beta3).
  12. Benjamin Franzke uploaded patch set 2 02/12/21, 18:04

  13. Benjamin Franzke commented on patch set 2 V +1 CR +1 02/12/21, 18:08

    Reply

    Alright, fixed the toolbar offset via data-bs-offset. Not nice, but works for now. The popover bug that richard found was already preset in beta1, although differently. The popover overlapped to the right of the screen, now it overlaps to the very left of the screen.
  14. TYPO3com voted on patch set 2 V +1 02/12/21, 18:13 Completed build in 08m 44s on Fri, 12 Feb, 06:13 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9508

  15. core-ci voted on patch set 2 V +1 02/12/21, 18:15 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/694

  16. Andreas Kienast voted on patch set 2 CR +1 02/12/21, 18:15

  17. Benjamin Franzke commented on patch set 2 02/12/21, 18:39

    Reply

    This one was broken before as well, so we can merge…

    Reply

    Fixed
  18. Georg Ringer voted on patch set 2 V +2 CR +2 02/12/21, 20:15

  19. Georg Ringer merged patch set 3 02/12/21, 20:15