67691[TASK] Use position sticky for docheader
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 8
- Build/Sources/Sass/component/_module.scss+19 −12
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DocumentHeader.ts2+19 −52
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DocumentSaveActions.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/SplitButtons.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ToggleSearchToolbox.ts+0 −2
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/DocumentHeader.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ToggleSearchToolbox.js+1 −1
Review log 1737
Show 512 earlier messages
-
Benjamin Franzke uploaded patch set 1 02/11/21, 12:50
-
Benjamin Franzke uploaded patch set 2 02/11/21, 12:52
-
TYPO3com voted on patch set 1 V -1 02/11/21, 12:59 Completed build in 08m 43s on Thu, 11 Feb, 12:59 PM Test Summary: 4 of 32841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9462
-
TYPO3com voted on patch set 2 V -1 02/11/21, 13:00 Completed build in 08m 06s on Thu, 11 Feb, 01:00 PM Test Summary: 4 of 32841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9463
-
core-ci voted on patch set 1 V -1 02/11/21, 13:01 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/639
-
Benjamin Franzke uploaded patch set 3 02/11/21, 13:03
-
core-ci voted on patch set 2 V -1 02/11/21, 13:06 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/640
-
Benjamin Franzke uploaded patch set 4 02/11/21, 13:11
-
TYPO3com voted on patch set 3 V -1 02/11/21, 13:12 Completed build in 08m 38s on Thu, 11 Feb, 01:12 PM Test Summary: 2 of 32841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9464
-
core-ci voted on patch set 3 V -1 02/11/21, 13:17 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/641
-
Benjamin Franzke commented on patch set 4 CR -1 02/11/21, 13:19
on it, therefore CR -1. Will re-add full docheader reveal on scroll-up. -
TYPO3com voted on patch set 4 V -1 02/11/21, 13:21 Completed build in 09m 23s on Thu, 11 Feb, 01:21 PM Test Summary: 2 of 32841 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9465
-
core-ci voted on patch set 4 V -1 02/11/21, 13:22 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/642
-
Benjamin Franzke uploaded patch set 5 02/11/21, 13:51
-
Benjamin Franzke uploaded patch set 6 02/11/21, 13:54
-
TYPO3com voted on patch set 5 V -1 02/11/21, 13:59 Completed build in 08m 14s on Thu, 11 Feb, 01:59 PM Test Summary: 81 of 32846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9467
-
core-ci voted on patch set 5 V -1 02/11/21, 14:01 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/645
-
TYPO3com voted on patch set 6 V +1 02/11/21, 14:03 Completed build in 08m 33s on Thu, 11 Feb, 02:03 PM Test Summary: 32605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9468
-
Benjamin Franzke commented on patch set 6 CR -1 02/11/21, 14:04
DocumentHeader.ts:70Needs to be re-added. -
core-ci voted on patch set 6 V +1 02/11/21, 14:05 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/646
-
Benjamin Franzke uploaded patch set 7 02/11/21, 14:13
-
TYPO3com voted on patch set 7 V +1 02/11/21, 14:21 Completed build in 08m 30s on Thu, 11 Feb, 02:21 PM Test Summary: 32605 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9469
-
core-ci voted on patch set 7 V +1 02/11/21, 14:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/647
-
Benjamin Franzke commented on patch set 7 02/11/21, 14:54
DocumentHeader.ts:70ReplyFixed. -
Benjamin Franzke uploaded patch set 8 02/12/21, 08:58
Resolve Merge Conflict -
TYPO3com voted on patch set 8 V +1 02/12/21, 09:06 Completed build in 07m 16s on Fri, 12 Feb, 09:05 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9498
-
core-ci voted on patch set 8 V +1 02/12/21, 09:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/684
-
Richard Haeser voted on patch set 8 V +1 CR +1 02/12/21, 13:24
-
Benjamin Franzke uploaded patch set 9 02/12/21, 20:26
Resolve Merge Conflict -
Markus Klein updated the commit message in patch set 10 02/12/21, 20:32
-
TYPO3com voted on patch set 9 V +1 02/12/21, 20:35 Completed build in 09m 09s on Fri, 12 Feb, 08:35 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9509
-
Markus Klein voted on patch set 10 V +1 CR +1 02/12/21, 20:38
-
core-ci voted on patch set 9 V +1 02/12/21, 20:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/695
-
TYPO3com voted on patch set 10 V +1 02/12/21, 20:40 Completed build in 07m 51s on Fri, 12 Feb, 08:40 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9511
-
Benni Mack voted on patch set 10 V +2 CR +2 02/12/21, 20:43
-
Benni Mack merged patch set 11 02/12/21, 20:43
-
core-ci voted on patch set 10 V +1 02/12/21, 20:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/697