Review main Merged

67772[BUGFIX] Recognize removed columns on PostgreSQL

Stephan Großberndt CR +2 V +2 Easy +23 −10 updated 02/23/21, 07:29

Commit message

This patch ensures columns of tables which have been removed from
ext_tables.sql definitions are recognized on PostgreSQL so they are
renamed by adding a "zzz_deleted_" prefix.

It also enables the formerly excluded according test for SQLite and
MSSQL which work without necessary changes.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 914

  1. Stephan Großberndt uploaded patch set 1 02/11/21, 16:48

  2. Stephan Großberndt wrote 02/11/21, 16:54

    Topic set to postgresql
  3. core-ci voted on patch set 1 V +1 02/11/21, 17:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/653

  4. Stephan Großberndt uploaded patch set 2 02/11/21, 17:30

  5. TYPO3com voted on patch set 2 V +1 02/11/21, 17:39 Completed build in 08m 49s on Thu, 11 Feb, 05:39 PM Test Summary: 32607 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9477

  6. core-ci voted on patch set 2 V +1 02/11/21, 17:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/655

  7. Christian Kuhn updated the commit message in patch set 3 02/11/21, 21:25

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 02/11/21, 21:26

  9. TYPO3com voted on patch set 3 V +1 02/11/21, 21:34 Completed build in 09m 15s on Thu, 11 Feb, 09:34 PM Test Summary: 32613 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9484

  10. core-ci voted on patch set 3 V +1 02/11/21, 21:34 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/668

  11. Markus Klein voted on patch set 3 V +1 CR +1 02/12/21, 13:25

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 02/22/21, 13:30

  13. Christian Kuhn merged patch set 4 02/22/21, 13:30

  14. Benni Mack wrote 02/23/21, 07:29

    Created a revert of this change as I6513f76f537c04e4ebe06cae4a475c5d8d7fbbf8