Review main Abandoned

67872[POC][WIP][TASK] Merge MFA Manifest into a combined provider instace

Benjamin Franzke CR 0 V 0 Hard +395 −413 updated 02/12/21, 13:53

Commit message

This is just a proposal, intended to be merged into
https://review.typo3.org/c/Packages/TYPO3.CMS/+/67548

This patch adapts the manifest to be an adapter
for the real provider that is implemented by extensions.
The manifest is automatically created by the DI factory,
and configured through service tags.

Also, this patch now pass MfaProviderPropertyManager around,
instead of the abstract AbstractUserAuthentication, in order
to not settle AbstractUserAuthentication into an Interface
right now, which would then be hard to change.

TODO:
 * Maybe rename MfaProviderPropertyManager to
   PropertyStore or ProviderPropertyStore

Review

  • Code review CR 0
  • Verified V 0

Files 24

Show 4 more files

Review log 35

  1. Benjamin Franzke uploaded patch set 1 02/11/21, 20:36

  2. TYPO3com voted on patch set 1 V -1 02/11/21, 20:37 Completed build in 21s on Thu, 11 Feb, 08:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9482

  3. core-ci voted on patch set 1 V -1 02/11/21, 20:48 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/665

  4. Benjamin Franzke marked it work in progress 02/11/21, 23:33

  5. Benjamin Franzke abandoned the change 02/12/21, 13:53