Review main Merged

67893[FEATURE] Enable multi-level language fallback for rendered content

Gordon Brüggemann CR +2 V +2 Hard +191 −88 updated 01/18/23, 09:03

Commit message

This change enables functionality of every content
to use the fallback chain to loop over each fallback language
to check for a fallback content in a different language ID.

This is now in line with the page resolving fallback handling
and finally completes the options within site configuration
"fallbackChain".

This works in Extbase and TypoScript environments.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 4896

Show 3371 earlier messages
  1. Gordon Brüggemann uploaded patch set 1 02/11/21, 21:22

  2. TYPO3com voted on patch set 1 V -1 02/11/21, 21:22 Completed build in 12s on Thu, 11 Feb, 09:22 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9483

  3. core-ci voted on patch set 1 V -1 02/11/21, 21:23 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/667

  4. Gordon Brüggemann uploaded patch set 2 02/11/21, 21:44

  5. TYPO3com commented on patch set 2 02/11/21, 21:44 Completed build in 12s on Thu, 11 Feb, 09:44 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9485

  6. core-ci commented on patch set 2 02/11/21, 21:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/669

  7. Gordon Brüggemann uploaded patch set 3 02/11/21, 21:52

  8. Gordon Brüggemann updated the commit message in patch set 4 02/11/21, 21:57

  9. TYPO3com voted on patch set 3 V -1 02/11/21, 22:00 Completed build in 07m 33s on Thu, 11 Feb, 10:00 PM Test Summary: 278 of 32852 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9488

  10. TYPO3com voted on patch set 4 V -1 02/11/21, 22:06 Completed build in 08m 17s on Thu, 11 Feb, 10:06 PM Test Summary: 278 of 32852 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9491

  11. core-ci voted on patch set 3 V -1 02/11/21, 22:09 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/672

  12. core-ci voted on patch set 4 V -1 02/11/21, 22:14 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/675

  13. Benni Mack uploaded patch set 5 02/19/21, 08:08

  14. TYPO3com voted on patch set 5 V -1 02/19/21, 08:17 Completed build in 09m 34s on Fri, 19 Feb, 08:17 AM Test Summary: 278 of 32864 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9627

  15. core-ci voted on patch set 5 V -1 02/19/21, 08:18 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/848

  16. Benni Mack uploaded patch set 6 02/19/21, 09:16

  17. Benni Mack uploaded patch set 7 02/19/21, 09:24

  18. TYPO3com voted on patch set 6 V -1 02/19/21, 09:25 Completed build in 08m 50s on Fri, 19 Feb, 09:25 AM Test Summary: 48 of 32864 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9628

  19. core-ci voted on patch set 6 V -1 02/19/21, 09:27 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/849

  20. TYPO3com voted on patch set 7 V -1 02/19/21, 09:34 Completed build in 09m 34s on Fri, 19 Feb, 09:34 AM Test Summary: 54 of 32864 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9629

  21. core-ci voted on patch set 7 V -1 02/19/21, 09:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/850

  22. Benni Mack uploaded patch set 8 02/19/21, 10:32

  23. TYPO3com voted on patch set 8 V -1 02/19/21, 10:40 Completed build in 08m 06s on Fri, 19 Feb, 10:40 AM Test Summary: 45 of 32864 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9630

  24. core-ci voted on patch set 8 V -1 02/19/21, 10:42 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/851

  25. Benni Mack uploaded patch set 9 05/10/21, 19:27

  26. core-ci voted on patch set 9 V -1 05/10/21, 21:33 Core CI is not happy: https://gitlab.typo3.org/TYPO3/CI/cms/-/pipelines/11361

  27. Benni Mack rebased onto patch set 10 08/05/21, 19:46

  28. core-ci voted on patch set 10 V -1 08/05/21, 21:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14167

  29. Benni Mack uploaded patch set 11 08/23/21, 16:04

  30. Anja Leichsenring rebased onto patch set 12 08/23/21, 16:53

  31. core-ci voted on patch set 11 V -1 08/23/21, 18:11 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15419

  32. core-ci voted on patch set 12 V -1 08/23/21, 18:56 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15424

  33. Gordon Brüggemann rebased onto patch set 13 08/25/21, 20:10

  34. core-ci voted on patch set 13 V -1 08/25/21, 22:14 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15627

  35. Gordon Brüggemann rebased onto patch set 14 08/27/21, 17:33

  36. Gordon Brüggemann uploaded patch set 15 08/27/21, 17:46

  37. core-ci voted on patch set 15 V -1 08/27/21, 17:52 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15746

  38. core-ci voted on patch set 14 V -1 08/27/21, 19:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15744

  39. Gordon Brüggemann uploaded patch set 16 08/27/21, 20:52

  40. core-ci voted on patch set 16 V -1 08/27/21, 20:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15753

  41. Gordon Brüggemann uploaded patch set 17 08/27/21, 21:09

  42. core-ci voted on patch set 17 V -1 08/27/21, 21:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15754

  43. Gordon Brüggemann uploaded patch set 18 08/28/21, 20:21

  44. core-ci voted on patch set 18 V -1 08/28/21, 20:47 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15785

  45. Gordon Brüggemann rebased onto patch set 19 08/30/21, 10:51

  46. core-ci voted on patch set 19 V -1 08/30/21, 11:12 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15853

  47. Benni Mack commented on patch set 19 CR -1 09/01/21, 09:51

    Somehow your latest updates now contain cleanups in PageRepository as well, I'm going to resolve this.
  48. Benni Mack uploaded patch set 20 09/01/21, 09:58

  49. core-ci voted on patch set 20 V -1 09/01/21, 10:21 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16004

  50. Benni Mack uploaded patch set 21 09/02/21, 19:42

  51. core-ci voted on patch set 21 V -1 09/02/21, 19:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16125

  52. Benni Mack uploaded patch set 22 09/02/21, 20:10

  53. Benni Mack uploaded patch set 23 09/02/21, 20:11

  54. core-ci voted on patch set 22 V -1 09/02/21, 20:15 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16128

  55. core-ci voted on patch set 23 V -1 09/02/21, 20:16 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16129

  56. Benni Mack uploaded patch set 24 09/02/21, 20:42

  57. core-ci voted on patch set 24 V -1 09/02/21, 22:45 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16133

  58. Benni Mack wrote 11/29/21, 10:09

    Change destination moved from master to main
  59. Benni Mack updated the commit message in patch set 25 11/29/21, 13:26

  60. core-ci voted on patch set 25 V -1 11/29/21, 18:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20026

  61. Benni Mack uploaded patch set 26 12/01/21, 22:09

  62. core-ci voted on patch set 26 V -1 12/02/21, 00:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20371

  63. Benni Mack uploaded patch set 27 01/21/22, 20:06

  64. core-ci voted on patch set 27 V -1 01/21/22, 22:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22373

  65. Benni Mack rebased onto patch set 28 01/22/22, 12:15

  66. core-ci voted on patch set 28 V -1 01/22/22, 14:18 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22404

  67. Benni Mack uploaded patch set 29 07/14/22, 19:03

  68. core-ci voted on patch set 29 V -1 07/14/22, 19:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29166

  69. Benni Mack uploaded patch set 30 07/15/22, 09:20

  70. core-ci voted on patch set 30 V -1 07/15/22, 09:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29197

  71. Benni Mack uploaded patch set 31 09/08/22, 19:59

  1. core-ci voted on patch set 31 V -1 09/08/22, 20:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30863

  2. Benni Mack uploaded patch set 32 09/09/22, 09:51

  3. core-ci voted on patch set 32 V -1 09/09/22, 10:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30904

  4. Benni Mack uploaded patch set 33 V -1 01/10/23, 17:17

  5. core-ci voted on patch set 33 V -1 01/10/23, 17:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35655

  6. Benni Mack commented on patch set 34 V -1 01/14/23, 20:04

    Published edit on patch set 33.
  7. core-ci voted on patch set 34 V -1 01/14/23, 20:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35801

  8. Oliver Hader commented on patch set 34 01/17/23, 10:10

    PageRepository.php:410

    I guess it should be `getPageOverlay($row, $langAspect)` instead?

    PageRepository.php:415

    This var contains multiple(!) records... that's why the 'pid' key is not found.
  9. Oliver Hader uploaded patch set 35 V -1 01/17/23, 10:10

  10. core-ci voted on patch set 35 V -1 01/17/23, 10:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35920

  11. Benni Mack uploaded patch set 36 V -1 01/17/23, 19:50

  12. Benni Mack commented on patch set 36 01/17/23, 19:55

    PageRepository.php:410 Reply

    Done

    PageRepository.php:415 Reply

    Done
  13. core-ci voted on patch set 36 V +1 01/17/23, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36016

  14. Benni Mack uploaded patch set 37 V +1 01/17/23, 20:39

  15. core-ci voted on patch set 37 V -1 01/17/23, 20:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36025

  16. Benni Mack commented on patch set 38 V -1 01/17/23, 21:00

    Published edit on patch set 37.
  17. core-ci voted on patch set 38 V -1 01/17/23, 21:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36031

  18. Benni Mack rebased onto patch set 39 V -1 01/17/23, 21:37

  19. core-ci voted on patch set 39 V +1 01/17/23, 21:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36037

  20. Benni Mack uploaded patch set 40 V +1 01/17/23, 22:06

  21. core-ci voted on patch set 40 V +1 01/17/23, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36042

  22. Oli Bartsch voted on patch set 40 CR +1 01/17/23, 22:36

  23. Oli Bartsch voted on patch set 40 V +1 01/18/23, 08:51

  24. Benni Mack voted on patch set 40 V +2 CR +2 01/18/23, 09:03

  25. Benni Mack merged patch set 41 01/18/23, 09:03