Review main Merged

67913[TASK] Build / CI: Get all exception codes of TYPO3 on CLI

Alexander Nitsche CR +2 V +2 Normal +182 −61 updated 02/17/21, 20:26

Commit message

All exception codes of the current TYPO3 version can be output
to stdout without checking for missing and duplicate exception codes.

Therefore, the patch adds the `-p` option to the
duplicateExceptionCodeCheck.sh:

Build/Scripts/duplicateExceptionCodeCheck.sh -p

It is also added to runTests.sh:

Build/Scripts/runTests.sh -s listExceptionCodes

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 1325

  1. Alexander Nitsche uploaded patch set 1 02/12/21, 16:35

  2. TYPO3com voted on patch set 1 V +1 02/12/21, 16:43 Completed build in 08m 07s on Fri, 12 Feb, 04:43 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9506

  3. core-ci voted on patch set 1 V +1 02/12/21, 16:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/692

  4. Benni Mack updated the commit message in patch set 2 02/12/21, 20:28

  5. TYPO3com voted on patch set 2 V +1 02/12/21, 20:38 Completed build in 09m 23s on Fri, 12 Feb, 08:38 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9510

  6. core-ci voted on patch set 2 V +1 02/12/21, 20:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/696

  7. Christian Kuhn commented on patch set 2 02/15/21, 09:35

    Mmm, I'm not sure if we should do this right now: The script is currently broken on gitlab-ci - it fails due to some option that is not available in the alpine busybox grep ... I'm planing to rewrite the script using php and nikic/php-parser instead. We would get rid of that nasty regex and could merge it with the other scripts that add visitors to php-parser, which would lead to quicker execution, too. Adding another option to the script now would then add additional trouble to these transition efforts. So, maybe wait a bit and have a second look when the script has been rewritten?
  8. Alexander Nitsche commented on patch set 2 02/15/21, 10:07

    Reply

    Thanks for the insights. But we need the list of exceptions now to proceed with the wiki.typo3.org->docs.typo3.org migration. This update should not have any negative effect: If the new option "-p" is not added it behaves as before: It fails for GitLab CI and works for Bamboo. As soon as there is a new PHP Script i would transfer the option happily to the new script.
  9. Alexander Nitsche uploaded patch set 3 02/15/21, 12:56

  10. TYPO3com voted on patch set 3 V +1 02/15/21, 13:04 Completed build in 07m 55s on Mon, 15 Feb, 01:04 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9544

  11. core-ci voted on patch set 3 V +1 02/15/21, 13:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/736

  12. Alexander Nitsche updated the commit message in patch set 4 02/15/21, 13:12

  13. TYPO3com voted on patch set 4 V +1 02/15/21, 13:21 Completed build in 08m 35s on Mon, 15 Feb, 01:21 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9545

  14. core-ci voted on patch set 4 V +1 02/15/21, 13:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/737

  15. Alexander Nitsche uploaded patch set 5 02/17/21, 10:01

  16. Alexander Nitsche uploaded patch set 6 02/17/21, 10:09

  17. TYPO3com voted on patch set 5 V +1 02/17/21, 10:09 Completed build in 08m 20s on Wed, 17 Feb, 10:09 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9584

  18. core-ci voted on patch set 5 V +1 02/17/21, 10:12 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/793

  19. TYPO3com voted on patch set 6 V +1 02/17/21, 10:19 Completed build in 09m 46s on Wed, 17 Feb, 10:19 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9586

  20. core-ci voted on patch set 6 V +1 02/17/21, 10:25 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/795

  21. Alexander Nitsche commented on patch set 6 02/17/21, 11:58

    The mentioned Gitlab CI problem has been tackled in meantime by Christian Kuhn by replacing the busybox grep of Alpine Linux by the common GNU grep. Next, i changed the script behavior as it ignores missing and duplicate exception code checks when explicitly listing instead of checking exception codes of a TYPO3 release as this was required for some older TYPO3 releases. The final exception codes list has unique exception codes nevertheless. Last, the printed JSON list handles empty lists now too.
  22. Christian Kuhn voted on patch set 6 V +1 CR +1 02/17/21, 20:25

  23. Anja Leichsenring voted on patch set 6 V +1 CR +1 02/17/21, 20:26

  24. Christian Kuhn voted on patch set 6 V +2 CR +2 02/17/21, 20:26

  25. Christian Kuhn merged patch set 7 02/17/21, 20:26