67915[TASK] Deprecate usage of jQuery in Tooltip module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Martin Kutschker +1
-
Verified V +2 Done
- Benni Mack +2
- Martin Kutschker +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Tooltip.ts10+62 −16
- Build/Sources/TypeScript/recordlist/Resources/Public/TypeScript/Tooltip.ts+3 −3
- typo3/sysext/backend/Resources/Public/JavaScript/Tooltip.js+1 −1
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-93506-JQueryInTooltips.rstnew+37 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/Tooltip.js+1 −1
Review log 1222
-
Andreas Kienast uploaded patch set 1 02/13/21, 16:08
-
TYPO3com voted on patch set 1 V +1 02/13/21, 16:16 Completed build in 07m 37s on Sat, 13 Feb, 04:16 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9516
-
core-ci voted on patch set 1 V +1 02/13/21, 16:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/704
-
Andreas Kienast uploaded patch set 2 02/13/21, 16:19
-
Andreas Kienast uploaded patch set 3 02/13/21, 16:22
-
TYPO3com voted on patch set 2 V +1 02/13/21, 16:28 Completed build in 08m 21s on Sat, 13 Feb, 04:28 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9517
-
TYPO3com voted on patch set 3 V +1 02/13/21, 16:30 Completed build in 08m 39s on Sat, 13 Feb, 04:30 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9518
-
core-ci voted on patch set 2 V +1 02/13/21, 16:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/705
-
core-ci voted on patch set 3 V +1 02/13/21, 16:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/706
-
Benjamin Franzke commented on patch set 3 02/13/21, 21:23
-
Andreas Kienast commented on patch set 3 02/14/21, 07:38
Tooltip.ts:59ReplyAck -
Andreas Kienast uploaded patch set 4 02/14/21, 07:39
-
TYPO3com voted on patch set 4 V +1 02/14/21, 07:47 Completed build in 07m 58s on Sun, 14 Feb, 07:47 AM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9521
-
core-ci voted on patch set 4 V +1 02/14/21, 07:50 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/711
-
Martin Kutschker commented on patch set 4 V +1 CR +1 02/14/21, 16:53
Tooltip.ts:36With "options: Partial<BootstrapTooltip.Options> = {}" you can remove the classic initialization code.Tooltip.ts:40element is const within the loop.Tooltip.ts:67node is const within the loop.Tooltip.ts:94node is const within the loop. -
Andreas Kienast uploaded patch set 5 02/14/21, 18:35
-
Andreas Kienast commented on patch set 5 02/14/21, 18:39
Tooltip.ts:36ReplyDoneTooltip.ts:40ReplyDoneTooltip.ts:67ReplyDoneTooltip.ts:94ReplyDone -
TYPO3com voted on patch set 5 V +1 02/14/21, 18:42 Completed build in 07m 21s on Sun, 14 Feb, 06:42 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9525
-
core-ci voted on patch set 5 V +1 02/14/21, 18:45 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/714
-
Martin Kutschker voted on patch set 5 V +1 CR +1 02/14/21, 21:17
-
Benni Mack voted on patch set 5 V +2 CR +2 02/15/21, 07:49
-
Benni Mack merged patch set 6 02/15/21, 07:50
Tooltip.ts:59