Review main Abandoned

67916[TASK] give the almost full example MyMap

TYPO3com CR 0 V 0 Easy +4 −1 updated 04/27/21, 19:54

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 25

  1. TYPO3com uploaded patch set 1 02/13/21, 17:50

  2. TYPO3com voted on patch set 1 V +1 02/13/21, 17:58 Completed build in 08m 21s on Sat, 13 Feb, 05:58 PM Test Summary: 32611 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9519

  3. core-ci voted on patch set 1 V +1 02/13/21, 18:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/707

  4. Christian Kuhn commented on patch set 1 CR -1 02/14/21, 21:10

    Thanks for your change, Franz. Your change however imho does not improve things: A 'renderType' is a much more powerful solution than a 'userFunc': In general, it should not be needed to call some 'UserFunc' class to do the rendering. Instead, the 'render()' code should be within the according renderType class itself and should most likely not extract that to some additional sub class. Your solution encourages the use of an additional standalone class that seems to be there for backwards compatibility reasons. This is not the solution we want to encourage. Please refactor your code to include needed rendering within the registered renderType class instead. This it what it is designed for.
  5. Daniel Goerz abandoned the change 04/27/21, 19:54

    Abandoned due to lack of activity. Can be picked up any time if desired.