Review main Merged

67919[TASK] runTests.sh: Proper validation of -a option

Christian Kuhn CR +2 V +2 Normal +54 −15 updated 02/15/21, 09:40

Commit message

Plus: No variable fallback magick in docker-compose.yml,
this belongs to runTests.sh

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Simon Gilli +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Simon Gilli +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Christian Kuhn uploaded patch set 1 02/15/21, 09:27

  2. Simon Gilli voted on patch set 1 V +1 CR +1 02/15/21, 09:31

  3. TYPO3com voted on patch set 1 V +1 02/15/21, 09:36 Completed build in 08m 17s on Mon, 15 Feb, 09:36 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9535

  4. core-ci voted on patch set 1 V +1 02/15/21, 09:39 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/725

  5. Richard Haeser voted on patch set 1 V +2 CR +2 02/15/21, 09:40

  6. Richard Haeser merged patch set 2 02/15/21, 09:40