Review main Abandoned

67924[BUGFIX] Fix preview in workspace with plugins having model relations

Nikita Hovratov CR 0 V 0 Easy +6 −0 updated 04/30/21, 10:14

Commit message

This resolves an issue where the PageRepository tries to overlay a
joined row of e.g. 'sys_category' and 'sys_category_record_mm'. This
leads to a select query with non existing columns. To prevent this from
happening we remove all foreign columns which are not present in TCA.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1123

  1. Nikita Hovratov uploaded patch set 1 02/15/21, 17:53

  2. TYPO3com voted on patch set 1 V -1 02/15/21, 17:53 Completed build in 12s on Mon, 15 Feb, 05:53 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9549

  3. core-ci voted on patch set 1 V -1 02/15/21, 17:54 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/742

  4. Nikita Hovratov uploaded patch set 2 02/15/21, 17:54

  5. TYPO3com voted on patch set 2 V -1 02/15/21, 18:01 Completed build in 06m 32s on Mon, 15 Feb, 06:01 PM Test Summary: 18 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9550

  6. core-ci voted on patch set 2 V -1 02/15/21, 18:05 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/743

  7. Nikita Hovratov uploaded patch set 3 02/15/21, 18:28

  8. TYPO3com voted on patch set 3 V -1 02/15/21, 18:36 Completed build in 08m 03s on Mon, 15 Feb, 06:36 PM Test Summary: 18 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9551

  9. core-ci voted on patch set 3 V -1 02/15/21, 18:39 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/744

  10. Nikita Hovratov uploaded patch set 4 02/16/21, 09:17

  11. TYPO3com voted on patch set 4 V +1 02/16/21, 09:25 Completed build in 07m 52s on Tue, 16 Feb, 09:25 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9562

  12. core-ci voted on patch set 4 V +1 02/16/21, 09:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/763

  13. Tymoteusz Motylewski commented on patch set 4 02/26/21, 22:40

    is there a way to avoid this additional db query?
  14. Nikita Hovratov uploaded patch set 5 02/27/21, 08:45

  15. Nikita Hovratov commented on patch set 5 02/27/21, 08:50

    Reply

    Should work with comparing TCA columns.
  16. TYPO3com voted on patch set 5 V -1 02/27/21, 08:54 Completed build in 08m 53s on Sat, 27 Feb, 08:54 AM Test Summary: 18 of 32969 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9745

  17. core-ci voted on patch set 5 V -1 02/27/21, 08:57 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1038

  18. Nikita Hovratov uploaded patch set 6 02/27/21, 09:11

  19. TYPO3com voted on patch set 6 V +1 02/27/21, 09:17 Completed build in 06m 32s on Sat, 27 Feb, 09:17 AM Test Summary: 32726 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9747

  20. core-ci voted on patch set 6 V +1 02/27/21, 09:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1041

  21. Richard Haeser voted on patch set 6 CR +1 02/28/21, 10:16

  22. Benni Mack commented on patch set 6 04/29/21, 17:01

    Hey Nikita, just saw your change (after working for days on the same fix), thanks for the tips. My approach is this one https://review.typo3.org/c/Packages/TYPO3.CMS/+/68915 which keeps the queried, and JOINed fields within the SQL, and only does 1 additional query if the record is in a Workspace + a JOIN is happening.
  23. Nikita Hovratov abandoned the change 04/30/21, 10:14