Review main Merged

67925[BUGFIX] Quote identifier `colPos` in documentation example

TYPO3com CR +2 V +2 Easy +1 −1 updated 02/15/21, 22:01

Commit message

The `colPos` identifier must be quoted - triggered by `{#colPos}`
in TypoScript - to make the database query work on database systems
that support case-sensitive identifiers (e.g. like PostgreSQL).

See
https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/8.7/Importa
nt-80506-DbalCompatibleFieldQuotingInTypoScript.html and
https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Functions
/Select.html#quoting-of-fields

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 815

  1. TYPO3com uploaded patch set 1 02/15/21, 18:52

  2. Stephan Großberndt updated the commit message in patch set 2 02/15/21, 18:55

  3. Oliver Hader commented on patch set 2 02/15/21, 18:56

    Please use "quote identifier" instead of "escape" - escaping implies some security implications, which is not valid in this case
  4. Oliver Hader updated the commit message in patch set 3 02/15/21, 18:59

  5. Oliver Hader voted on patch set 3 CR +1 02/15/21, 18:59

  6. TYPO3com voted on patch set 1 V +1 02/15/21, 19:01 Completed build in 08m 42s on Mon, 15 Feb, 07:01 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9553

  7. TYPO3com voted on patch set 2 V +1 02/15/21, 19:03 Completed build in 07m 53s on Mon, 15 Feb, 07:03 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9554

  8. core-ci voted on patch set 1 V +1 02/15/21, 19:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/746

  9. TYPO3com voted on patch set 3 V +1 02/15/21, 19:08 Completed build in 09m 20s on Mon, 15 Feb, 07:08 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9555

  10. core-ci voted on patch set 2 V +1 02/15/21, 19:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/747

  11. core-ci voted on patch set 3 V +1 02/15/21, 19:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/748

  12. Christian Kuhn voted on patch set 3 V +1 CR +1 02/15/21, 19:53

  13. Anja Leichsenring voted on patch set 3 V +2 CR +2 02/15/21, 19:55

  14. Anja Leichsenring merged patch set 4 02/15/21, 19:55

  15. Stephan Großberndt commented on patch set 4 02/15/21, 22:01

    Reply

    Will do, thanks for the reminder.
    Thanks for the quick review and merge.