Review main Merged

67930[FEATURE] Possibility to disable hreflang per page

Richard Haeser CR +2 V +2 Normal +58 −2 updated 02/24/21, 20:20

Commit message

If you have a good reason to disable the default rendering of
hreflang tags, you can now use a TypoScript setting.

To disable the hreflang generation, you can add the following
line to your TypoScript setup.

.. code-block:: typoscript

   config.disableHrefLang = 1

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • Torben Hansen +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Guido Schmechel +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 5

Review log 812

  1. Richard Haeser uploaded patch set 1 02/16/21, 09:47

  2. TYPO3com voted on patch set 1 V -1 02/16/21, 09:56 Completed build in 09m 06s on Tue, 16 Feb, 09:56 AM Test Summary: 26 of 32868 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9565

  3. core-ci voted on patch set 1 V -1 02/16/21, 09:58 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/766

  4. Richard Haeser uploaded patch set 2 02/16/21, 10:41

  5. TYPO3com voted on patch set 2 V +1 02/16/21, 10:49 Completed build in 07m 56s on Tue, 16 Feb, 10:49 AM Test Summary: 32627 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9568

  6. core-ci voted on patch set 2 V +1 02/16/21, 10:51 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/769

  7. Jörg Bösche commented on patch set 2 CR +1 02/16/21, 21:09

    A good catch and job!
  8. Guido Schmechel commented on patch set 2 V +1 CR +1 02/21/21, 11:44

    Works as expected :-) Just a friendly reminder: We have to modify the documentation, too: https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/Setup/Config/Index.html
  9. Richard Haeser commented on patch set 2 02/21/21, 12:13

  10. Torben Hansen voted on patch set 2 CR +1 02/23/21, 14:52

  11. Georg Ringer voted on patch set 2 V +2 CR +2 02/24/21, 20:20

  12. Georg Ringer merged patch set 3 02/24/21, 20:20