Review main Merged

67952[BUGFIX] Fix margins of form labels

Benni Mack CR +2 V +2 Easy +10 −3 updated 02/16/21, 15:02

Commit message

Labels within FormEngine are bold, but due to Boostrap 5
all labels in all places were bold and created margin, making
the rendering of the rest of the TYPO3 Backend hard-to-grasp,
as well as FormEngine not allowing to have a different view
for labels of fields, and labels of actual form elements.

This change adapts the margin and font-weight accordingly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack uploaded patch set 1 02/16/21, 10:17

  2. TYPO3com voted on patch set 1 V +1 02/16/21, 10:25 Completed build in 08m 09s on Tue, 16 Feb, 10:25 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9567

  3. core-ci voted on patch set 1 V +1 02/16/21, 10:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/768

  4. Richard Haeser voted on patch set 1 V +1 CR +1 02/16/21, 10:49

  5. Oli Bartsch voted on patch set 1 V +1 CR +1 02/16/21, 15:01

  6. Benni Mack voted on patch set 1 V +2 CR +2 02/16/21, 15:02

  7. Benni Mack merged patch set 2 02/16/21, 15:02