Review main Merged

67953[TASK] Streamline Web->Template module UI

Benni Mack CR +2 V +2 Hard +422 −466 updated 02/18/21, 08:46

Commit message

This change reduces technical debt on the HTML/CSS side
by utilizing Fluid templates and Bootstrap 5 utilities in favor
of home-grown code for Web->Template module.

Most important changes:
* Move as much logic from Controller in the Views (removal of LLprefix)
* Unify module settings to be on top of the module and not below a listing
* Streamline checkboxes
* Remove inline CSS code

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 17

Review log 2851

Show 1126 earlier messages
  1. Benni Mack uploaded patch set 1 02/16/21, 13:50

  2. TYPO3com voted on patch set 1 V -1 02/16/21, 13:59 Completed build in 08m 22s on Tue, 16 Feb, 01:59 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9569

  3. core-ci voted on patch set 1 V -1 02/16/21, 14:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/771

  4. Benni Mack uploaded patch set 2 02/16/21, 14:24

  5. TYPO3com voted on patch set 2 V -1 02/16/21, 14:33 Completed build in 08m 17s on Tue, 16 Feb, 02:33 PM Test Summary: 8 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9571

  6. core-ci voted on patch set 2 V -1 02/16/21, 14:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/773

  7. TYPO3com commented on patch set 2 02/16/21, 14:41 Completed build in 24m 39s on Tue, 16 Feb, 02:41 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9571

  8. Benni Mack uploaded patch set 3 02/16/21, 14:54

  9. TYPO3com voted on patch set 3 V -1 02/16/21, 15:03 Completed build in 08m 57s on Tue, 16 Feb, 03:03 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9572

  10. core-ci voted on patch set 3 V -1 02/16/21, 15:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/774

  11. Benni Mack uploaded patch set 4 02/16/21, 16:30

  12. TYPO3com voted on patch set 4 V -1 02/16/21, 16:38 Completed build in 08m 38s on Tue, 16 Feb, 04:38 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9576

  13. core-ci voted on patch set 4 V -1 02/16/21, 17:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/778

  14. Benni Mack uploaded patch set 5 02/17/21, 09:45

  15. TYPO3com voted on patch set 5 V -1 02/17/21, 09:53 Completed build in 07m 59s on Wed, 17 Feb, 09:53 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9583

  16. core-ci voted on patch set 5 V -1 02/17/21, 09:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/792

  17. Benni Mack uploaded patch set 6 02/17/21, 10:07

  18. TYPO3com voted on patch set 6 V +1 02/17/21, 10:16 Completed build in 08m 37s on Wed, 17 Feb, 10:16 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9585

  19. core-ci voted on patch set 6 V +1 02/17/21, 10:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/794

  20. Richard Haeser commented on patch set 6 02/17/21, 12:37

    TemplateObjectBrowserModuleFunction.html:66

    This is causing the button below this one, to have no margin between those buttons.

    TemplateObjectBrowserModuleFunction.html:156

    I think we should solve this in a different way. I know lots of sites which has plenty of conditions (you might argue if that's a good thing) which will cause that you have to scroll always before having an overview of the values set. I think it is more logical to have them above the properties, but maybe we should have this collapsable or something like that.
  21. Oli Bartsch uploaded patch set 7 02/17/21, 14:35

  22. Oli Bartsch commented on patch set 7 V +1 CR +1 02/17/21, 14:37

    TemplateObjectBrowserModuleFunction.html:66 Reply

    Done

    TemplateObjectBrowserModuleFunction.html:156 Reply

    Added a collapsible panel for it.
  23. TYPO3com voted on patch set 7 V +1 02/17/21, 14:43 Completed build in 08m 23s on Wed, 17 Feb, 02:43 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9591

  24. core-ci voted on patch set 7 V +1 02/17/21, 14:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/800

  25. Richard Haeser uploaded patch set 8 02/17/21, 14:55

  26. Richard Haeser voted on patch set 8 V +1 CR +1 02/17/21, 14:59

  1. TYPO3com voted on patch set 8 V +1 02/17/21, 15:03 Completed build in 07m 43s on Wed, 17 Feb, 03:03 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9592

  2. Oli Bartsch commented on patch set 8 02/17/21, 15:06

    locallang_objbrowser.xlf:124

    "1 active conditions" Maybe we just use "Active conditions"
  3. core-ci voted on patch set 8 V +1 02/17/21, 15:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/801

  4. Richard Haeser uploaded patch set 9 02/17/21, 15:07

  5. Richard Haeser commented on patch set 8 02/17/21, 15:09

    locallang_objbrowser.xlf:124 Reply Unresolved

    Fixed by "active condition(s)". Just showing that there are active conditions might work as well indeed, although showing the number of active conditions might help for some people.
  6. TYPO3com voted on patch set 9 V +1 02/17/21, 15:15 Completed build in 08m 20s on Wed, 17 Feb, 03:15 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9594

  7. core-ci voted on patch set 9 V +1 02/17/21, 15:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/803

  8. Richard Haeser voted on patch set 9 V +1 CR +1 02/17/21, 15:22

  9. Oli Bartsch voted on patch set 9 V +1 CR +1 02/17/21, 15:26

  10. Andreas Kienast commented on patch set 9 V -1 02/17/21, 15:51

    The TSOB now misses the "Search" button. I've asked Benni for feedback, will lift my -1 once this is resolved in either way.
  11. Richard Haeser commented on patch set 9 02/17/21, 15:53

    Reply Unresolved

    Good catch!
  12. Richard Haeser voted on patch set 9 V 0 CR 0 02/17/21, 15:53

  13. Andreas Kienast uploaded patch set 10 02/17/21, 17:14

  14. Andreas Kienast voted on patch set 10 V +1 CR +1 02/17/21, 17:15

  15. Andreas Kienast commented on patch set 10 02/17/21, 17:17

    BackendUtility.php:2499

    This change is intended. form-group doesn't exist anymore in Bootstrap 5 and the existing CSS makes usage within flex containers pretty hard. Additionally, BackendUtility::getDropdownMenu() is barely used. However, other places like the "Database integrity check" need some adoptions.
  16. TYPO3com voted on patch set 10 V +1 02/17/21, 17:23 Completed build in 08m 37s on Wed, 17 Feb, 05:23 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9600

  17. core-ci voted on patch set 10 V -1 02/17/21, 17:25 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/809

  18. Benni Mack rebased onto patch set 11 02/17/21, 21:10

  19. TYPO3com voted on patch set 11 V +1 02/17/21, 21:19 Completed build in 08m 58s on Wed, 17 Feb, 09:19 PM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9603

  20. core-ci voted on patch set 11 V +1 02/17/21, 21:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/818

  21. Benni Mack commented on patch set 11 02/17/21, 21:27

    BackendUtility.php:2499 Reply

    yes... and the info module, but I already worked on that https://review.typo3.org/c/Packages/TYPO3.CMS/+/67955 and hopefully this will make it into v11.1 as well.
  22. Andreas Kienast voted on patch set 11 V +1 CR +1 02/18/21, 06:32

  23. Oli Bartsch voted on patch set 11 V +1 CR +1 02/18/21, 08:46

  24. Richard Haeser voted on patch set 11 V +2 CR +2 02/18/21, 08:46

  25. Richard Haeser merged patch set 12 02/18/21, 08:46