67953[TASK] Streamline Web->Template module UI
Commit message
Review
-
Code review CR +2 Done
- Richard Haeser +2
- Oli Bartsch +1
- Andreas Kienast +1
-
Verified V +2 Done
- Richard Haeser +2
- Oli Bartsch +1
- Andreas Kienast +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 17
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+1 −1
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+1 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+58 −93
- typo3/sysext/core/Tests/Acceptance/Backend/Template/TemplateCest.php+3 −4
- typo3/sysext/tstemplate/Classes/Controller/TemplateAnalyzerModuleFunctionController.php+4 −24
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateConstantEditorModuleFunctionController.php+3 −11
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateInformationModuleFunctionController.php+11 −16
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+2 −19
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateObjectBrowserModuleFunctionController.php+10 −15
- typo3/sysext/tstemplate/Configuration/Services.yaml+3 −0
- typo3/sysext/tstemplate/Resources/Private/Language/locallang_objbrowser.xlf2+3 −0
- typo3/sysext/tstemplate/Resources/Private/Templates/ConstantEditor.html+46 −27
- typo3/sysext/tstemplate/Resources/Private/Templates/InformationModule.html+21 −33
- typo3/sysext/tstemplate/Resources/Private/Templates/Main.html+0 −1
- typo3/sysext/tstemplate/Resources/Private/Templates/NoTemplate.html+31 −19
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateAnalyzerModuleFunction.html+55 −49
- typo3/sysext/tstemplate/Resources/Private/Templates/TemplateObjectBrowserModuleFunction.html4+170 −153
Review log 2851
Show 1126 earlier messages
-
Benni Mack uploaded patch set 1 02/16/21, 13:50
-
TYPO3com voted on patch set 1 V -1 02/16/21, 13:59 Completed build in 08m 22s on Tue, 16 Feb, 01:59 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9569
-
core-ci voted on patch set 1 V -1 02/16/21, 14:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/771
-
Benni Mack uploaded patch set 2 02/16/21, 14:24
-
TYPO3com voted on patch set 2 V -1 02/16/21, 14:33 Completed build in 08m 17s on Tue, 16 Feb, 02:33 PM Test Summary: 8 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9571
-
core-ci voted on patch set 2 V -1 02/16/21, 14:35 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/773
-
TYPO3com commented on patch set 2 02/16/21, 14:41 Completed build in 24m 39s on Tue, 16 Feb, 02:41 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9571
-
Benni Mack uploaded patch set 3 02/16/21, 14:54
-
TYPO3com voted on patch set 3 V -1 02/16/21, 15:03 Completed build in 08m 57s on Tue, 16 Feb, 03:03 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9572
-
core-ci voted on patch set 3 V -1 02/16/21, 15:07 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/774
-
Benni Mack uploaded patch set 4 02/16/21, 16:30
-
TYPO3com voted on patch set 4 V -1 02/16/21, 16:38 Completed build in 08m 38s on Tue, 16 Feb, 04:38 PM Test Summary: 1 of 32862 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9576
-
core-ci voted on patch set 4 V -1 02/16/21, 17:38 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/778
-
Benni Mack uploaded patch set 5 02/17/21, 09:45
-
TYPO3com voted on patch set 5 V -1 02/17/21, 09:53 Completed build in 07m 59s on Wed, 17 Feb, 09:53 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9583
-
core-ci voted on patch set 5 V -1 02/17/21, 09:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/792
-
Benni Mack uploaded patch set 6 02/17/21, 10:07
-
TYPO3com voted on patch set 6 V +1 02/17/21, 10:16 Completed build in 08m 37s on Wed, 17 Feb, 10:16 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9585
-
core-ci voted on patch set 6 V +1 02/17/21, 10:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/794
-
Richard Haeser commented on patch set 6 02/17/21, 12:37
TemplateObjectBrowserModuleFunction.html:156I think we should solve this in a different way. I know lots of sites which has plenty of conditions (you might argue if that's a good thing) which will cause that you have to scroll always before having an overview of the values set. I think it is more logical to have them above the properties, but maybe we should have this collapsable or something like that. -
Oli Bartsch uploaded patch set 7 02/17/21, 14:35
-
Oli Bartsch commented on patch set 7 V +1 CR +1 02/17/21, 14:37
TemplateObjectBrowserModuleFunction.html:66ReplyDoneTemplateObjectBrowserModuleFunction.html:156ReplyAdded a collapsible panel for it. -
TYPO3com voted on patch set 7 V +1 02/17/21, 14:43 Completed build in 08m 23s on Wed, 17 Feb, 02:43 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9591
-
core-ci voted on patch set 7 V +1 02/17/21, 14:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/800
-
Richard Haeser uploaded patch set 8 02/17/21, 14:55
-
Richard Haeser voted on patch set 8 V +1 CR +1 02/17/21, 14:59
-
TYPO3com voted on patch set 8 V +1 02/17/21, 15:03 Completed build in 07m 43s on Wed, 17 Feb, 03:03 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9592
-
Oli Bartsch commented on patch set 8 02/17/21, 15:06
locallang_objbrowser.xlf:124"1 active conditions" Maybe we just use "Active conditions" -
core-ci voted on patch set 8 V +1 02/17/21, 15:06 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/801
-
Richard Haeser uploaded patch set 9 02/17/21, 15:07
-
Richard Haeser commented on patch set 8 02/17/21, 15:09
locallang_objbrowser.xlf:124Reply UnresolvedFixed by "active condition(s)". Just showing that there are active conditions might work as well indeed, although showing the number of active conditions might help for some people. -
TYPO3com voted on patch set 9 V +1 02/17/21, 15:15 Completed build in 08m 20s on Wed, 17 Feb, 03:15 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9594
-
core-ci voted on patch set 9 V +1 02/17/21, 15:19 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/803
-
Richard Haeser voted on patch set 9 V +1 CR +1 02/17/21, 15:22
-
Oli Bartsch voted on patch set 9 V +1 CR +1 02/17/21, 15:26
-
Andreas Kienast commented on patch set 9 V -1 02/17/21, 15:51
The TSOB now misses the "Search" button. I've asked Benni for feedback, will lift my -1 once this is resolved in either way. -
Richard Haeser commented on patch set 9 02/17/21, 15:53
Reply Unresolved
Good catch! -
Richard Haeser voted on patch set 9 V 0 CR 0 02/17/21, 15:53
-
Andreas Kienast uploaded patch set 10 02/17/21, 17:14
-
Andreas Kienast voted on patch set 10 V +1 CR +1 02/17/21, 17:15
-
Andreas Kienast commented on patch set 10 02/17/21, 17:17
BackendUtility.php:2499This change is intended. form-group doesn't exist anymore in Bootstrap 5 and the existing CSS makes usage within flex containers pretty hard. Additionally, BackendUtility::getDropdownMenu() is barely used. However, other places like the "Database integrity check" need some adoptions. -
TYPO3com voted on patch set 10 V +1 02/17/21, 17:23 Completed build in 08m 37s on Wed, 17 Feb, 05:23 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9600
-
core-ci voted on patch set 10 V -1 02/17/21, 17:25 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/809
-
Benni Mack rebased onto patch set 11 02/17/21, 21:10
-
TYPO3com voted on patch set 11 V +1 02/17/21, 21:19 Completed build in 08m 58s on Wed, 17 Feb, 09:19 PM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9603
-
core-ci voted on patch set 11 V +1 02/17/21, 21:21 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/818
-
Benni Mack commented on patch set 11 02/17/21, 21:27
BackendUtility.php:2499Replyyes... and the info module, but I already worked on that https://review.typo3.org/c/Packages/TYPO3.CMS/+/67955 and hopefully this will make it into v11.1 as well. -
Andreas Kienast voted on patch set 11 V +1 CR +1 02/18/21, 06:32
-
Oli Bartsch voted on patch set 11 V +1 CR +1 02/18/21, 08:46
-
Richard Haeser voted on patch set 11 V +2 CR +2 02/18/21, 08:46
-
Richard Haeser merged patch set 12 02/18/21, 08:46
TemplateObjectBrowserModuleFunction.html:66