Review main Merged

67955[TASK] Clean up Info module code

Benni Mack CR +2 V +2 Hard +332 −336 updated 02/18/21, 17:59

Commit message

This change:
* Removes any usages of TYPO3_REQUEST for the info module
  by handing over the current $request object into the TBE_MODULES_EXT
  codes
* Cleans up the HTML code + uses Bootstrap 5 markup
* Starts using constructor injection if applicable

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Richard Haeser +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 14

Review log 711

  1. Benni Mack uploaded patch set 1 02/16/21, 16:22

  2. TYPO3com voted on patch set 1 V +1 02/16/21, 16:31 Completed build in 08m 56s on Tue, 16 Feb, 04:31 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9575

  3. core-ci voted on patch set 1 V +1 02/16/21, 17:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/777

  4. Benni Mack uploaded patch set 2 02/18/21, 08:52

  5. TYPO3com voted on patch set 2 V +1 02/18/21, 09:00 Completed build in 08m 05s on Thu, 18 Feb, 09:00 AM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9611

  6. core-ci voted on patch set 2 V +1 02/18/21, 09:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/829

  7. Richard Haeser commented on patch set 2 V +1 CR +1 02/18/21, 15:56

    I see the button in the translation overview to view the page is not working correctly, but that is not related to this patch. As far as I can see everything still works and I don't see any issues.
  8. Christian Kuhn commented on patch set 2 02/18/21, 16:20

    Reply

    that button is broken for a while already, afaik, there is also a forge issue for it. i had a rough look years ago and came to the solution it's not trivial to fix ... no idea if that changed meanwhile.
  9. Christian Kuhn commented on patch set 2 CR -1 02/18/21, 16:20

    on it.
  10. Christian Kuhn commented on patch set 2 V +2 CR +2 02/18/21, 17:59

    a detail in localizationOverview is broken (before patch, too), can be fixed with another patch.
  11. Christian Kuhn merged patch set 3 02/18/21, 17:59