67955[TASK] Clean up Info module code
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Richard Haeser +1
-
Verified V +2 Done
- Christian Kuhn +2
- Richard Haeser +1
- TYPO3com +1 CI
- core-ci +1 CI
Issues 1
Files 14
- typo3/sysext/backend/Resources/Private/Partials/DocHeader.html+3 −3
- typo3/sysext/belog/Classes/Module/BackendLogModuleBootstrap.php+9 −9
- typo3/sysext/belog/Resources/Private/Partials/Content/Filter.html+127 −124
- typo3/sysext/belog/Resources/Private/Templates/BackendLog/List.html+4 −6
- typo3/sysext/info/Classes/Controller/InfoModuleController.php+19 −34
- typo3/sysext/info/Classes/Controller/InfoPageTyposcriptConfigController.php+20 −19
- typo3/sysext/info/Classes/Controller/PageInformationController.php+31 −36
- typo3/sysext/info/Classes/Controller/TranslationStatusController.php+59 −53
- typo3/sysext/info/Configuration/Services.yaml+9 −0
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Menu.html+11 −7
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/Page.html+1 −3
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/PageZero.html+38 −23
- typo3/sysext/info/Resources/Private/Partials/PageTsConfig/PageZeroTableRow.htmldeleted+0 −18
- typo3/sysext/info/Resources/Private/Templates/Main.html+1 −1
Review log 711
-
Benni Mack uploaded patch set 1 02/16/21, 16:22
-
TYPO3com voted on patch set 1 V +1 02/16/21, 16:31 Completed build in 08m 56s on Tue, 16 Feb, 04:31 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9575
-
core-ci voted on patch set 1 V +1 02/16/21, 17:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/777
-
Benni Mack uploaded patch set 2 02/18/21, 08:52
-
TYPO3com voted on patch set 2 V +1 02/18/21, 09:00 Completed build in 08m 05s on Thu, 18 Feb, 09:00 AM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9611
-
core-ci voted on patch set 2 V +1 02/18/21, 09:07 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/829
-
Richard Haeser commented on patch set 2 V +1 CR +1 02/18/21, 15:56
I see the button in the translation overview to view the page is not working correctly, but that is not related to this patch. As far as I can see everything still works and I don't see any issues. -
Christian Kuhn commented on patch set 2 02/18/21, 16:20
Reply
that button is broken for a while already, afaik, there is also a forge issue for it. i had a rough look years ago and came to the solution it's not trivial to fix ... no idea if that changed meanwhile. -
Christian Kuhn commented on patch set 2 CR -1 02/18/21, 16:20
on it. -
Christian Kuhn commented on patch set 2 V +2 CR +2 02/18/21, 17:59
a detail in localizationOverview is broken (before patch, too), can be fixed with another patch. -
Christian Kuhn merged patch set 3 02/18/21, 17:59