Review 10.4 Merged

67956[BUGFIX] Page module CE's in workspace with defLangBinding=1

Christian Kuhn CR +2 V +2 Easy +1 −1 updated 02/22/21, 13:27

Commit message

Changing a content element in a workspace when
mod.web_layout.defLangBinding = 1 is set on some upper
page makes the changed content element disappear from
page module view in "Languages" view. Fix this by
aligning uids in $defaultLanguageElementsByColumn
and $languageColumn properly.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Michael Semle +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Michael Semle +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 713

  1. Christian Kuhn uploaded patch set 1 02/16/21, 16:36

  2. TYPO3com voted on patch set 1 V +1 02/16/21, 16:45 Completed build in 08m 57s on Tue, 16 Feb, 04:45 PM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1109

  3. Christian Kuhn rebased onto patch set 2 02/16/21, 16:46

  4. Christian Kuhn updated the commit message in patch set 3 02/16/21, 16:49

  5. TYPO3com voted on patch set 2 V +1 02/16/21, 16:55 Completed build in 08m 46s on Tue, 16 Feb, 04:55 PM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1110

  6. TYPO3com voted on patch set 3 V +1 02/16/21, 16:58 Completed build in 08m 51s on Tue, 16 Feb, 04:58 PM Test Summary: 75335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-1111

  7. core-ci voted on patch set 1 V +1 02/16/21, 17:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/779

  8. core-ci voted on patch set 2 V +1 02/16/21, 17:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/780

  9. core-ci voted on patch set 3 V +1 02/16/21, 17:44 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/781

  10. Anja Leichsenring voted on patch set 3 V +1 CR +1 02/17/21, 20:10

  11. Michael Semle voted on patch set 3 V +1 CR +1 02/22/21, 12:06

  12. Christian Kuhn voted on patch set 3 V +2 CR +2 02/22/21, 13:27

  13. Christian Kuhn merged patch set 4 02/22/21, 13:27