67958[BUGFIX] Respect cookies in PageContentErrorHandler
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 2027
Show 2 earlier messages
-
TYPO3com voted on patch set 1 V +1 02/17/21, 08:31 Completed build in 08m 38s on Wed, 17 Feb, 08:31 AM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9582
-
core-ci voted on patch set 1 V +1 02/17/21, 08:33 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/791
-
Benni Mack voted on patch set 1 V +1 CR +1 02/19/21, 08:04
-
Oli Bartsch commented on patch set 1 02/19/21, 09:45
PageContentErrorHandler.php:81Are we sure "site" exists in any case here? -
Richard Haeser commented on patch set 1 02/19/21, 10:35
PageContentErrorHandler.php:81ReplyNot sure either. At least the exception will be catched, but not sure if thats intended behaviour. Maybe only add those cookie variables when site actually is a proper site object? But if we are sure site is always available, we are good to go. -
Oli Bartsch commented on patch set 1 02/19/21, 15:57
PageContentErrorHandler.php:81ReplyThis will lead to a fatal error (call to a member function on null) in Line 82 which can IMO not be caught. -
Georg Ringer uploaded patch set 2 02/22/21, 20:07
-
TYPO3com voted on patch set 2 V -1 02/22/21, 20:17 Completed build in 10m 06s on Mon, 22 Feb, 08:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9665
-
core-ci voted on patch set 2 V +1 02/22/21, 20:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/896
-
TYPO3com voted on patch set 2 V +1 02/25/21, 16:38 Completed build in 20h 41m 08s on Thu, 25 Feb, 04:38 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9665
-
Richard Haeser voted on patch set 2 V +1 CR +1 02/25/21, 21:06
-
Richard Haeser commented on patch set 2 02/25/21, 21:32
PageContentErrorHandler.php:81ReplyDone -
Oli Bartsch commented on patch set 2 CR -1 02/25/21, 23:22
Need to check this in detail for possible side effects, therefore -1 for now. -
Oli Bartsch commented on patch set 2 02/26/21, 11:25
Had another look at it now. I think it won't be a good idea to add those cookies to the request without checking the actual target, since this can also be external. -
Oliver Hader commented on patch set 2 CR -2 02/26/21, 11:46
Might have security implications - contacted author directly via Slack -
Richard Haeser commented on patch set 2 V 0 CR 0 02/26/21, 11:49
Good catch -
Georg Ringer uploaded patch set 3 03/24/21, 20:10
-
TYPO3com voted on patch set 3 V +1 03/24/21, 20:18 Completed build in 06m 59s on Wed, 24 Mar, 08:18 PM Test Summary: 32916 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10340
-
core-ci voted on patch set 3 V +1 03/24/21, 20:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1823
-
Oliver Hader commented on patch set 3 CR -1 03/24/21, 23:58
Uhm... now the error-cache is in place this might lead to exposing sensitive data for logged in users... -
Oliver Hader commented on patch set 3 03/25/21, 00:03
From my POV that means * forwarding cookies via sub-request should be declared explicitly via error-handling configuration (in YAML) * error-cache (caching HTTP response, that's different to pages cache) should either be build with a new partition for either current user group (gr_list) or user uid - both increasing the amount of cache items -
Benni Mack wrote 05/06/21, 15:27
Removed reviewer Benni Mack. -
Christian Kuhn commented on patch set 3 CR -1 05/06/21, 16:30
-1 from my side for sec reasons, too. I suggest to abandon this approach and set the issue no new again. -
Oliver Hader commented on patch set 3 08/03/21, 05:39
@Georg: What do you think? How to continue with this change? -
Georg Ringer abandoned the change 10/19/21, 18:50
abandoned, no interest