Review main Merged

67960[BUGFIX] Revert CSS changes regarding panel collapse state

Andreas Kienast CR +2 V +2 Easy +6 −6 updated 02/22/21, 09:24

Commit message

The changes done in #93453 introduced a CSS change that broke all
regular collapsible panels as their carets don't rotate anymore.

This bugfix reverts the CSS change and adopts the Flexform code to set
the `collapsed` class on a more appropriate element.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 2

Files 5

Review log 59

  1. Andreas Kienast uploaded patch set 1 02/17/21, 15:25

  2. Andreas Kienast updated the commit message in patch set 2 02/17/21, 15:26

  3. Oli Bartsch voted on patch set 2 V +1 CR +1 02/17/21, 15:29

  4. TYPO3com voted on patch set 1 V +1 02/17/21, 15:35 Completed build in 09m 29s on Wed, 17 Feb, 03:35 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9595

  5. TYPO3com voted on patch set 2 V +1 02/17/21, 15:35 Completed build in 08m 30s on Wed, 17 Feb, 03:35 PM Test Summary: 32621 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9596

  6. core-ci voted on patch set 1 V +1 02/17/21, 15:37 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/804

  7. core-ci voted on patch set 2 V +1 02/17/21, 15:40 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/805

  8. Benni Mack voted on patch set 2 V +2 CR +2 02/22/21, 09:24

  9. Benni Mack merged patch set 3 02/22/21, 09:24