Review main Merged

67961[BUGFIX] Use site name rather than pageUid for calling context menu

Anja Leichsenring CR +2 V +2 Easy +2 −2 updated 02/17/21, 19:56

Commit message

PageTree Acceptance tests must not rely on pageUids, as those can
change unexpected. Better to find the page via its title.

Credits to Christian Kuhn for coming up with the xpath.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Christian Kuhn +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 1

Review log 46

  1. Anja Leichsenring uploaded patch set 1 02/17/21, 19:37

  2. TYPO3com voted on patch set 1 V +1 02/17/21, 19:45 Completed build in 08m 21s on Wed, 17 Feb, 07:45 PM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9602

  3. core-ci voted on patch set 1 V +1 02/17/21, 19:48 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/812

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 02/17/21, 19:53

  5. Richard Haeser voted on patch set 1 V +2 CR +2 02/17/21, 19:56

  6. Richard Haeser merged patch set 2 02/17/21, 19:56