Review main Merged

67964[TASK] Use younger selenium/standalone-chrome

Christian Kuhn CR +2 V +2 Normal +38 −14 updated 02/25/21, 14:21

Commit message

This brings a recent chrome version. Some tests
need minor adaptions to deal with changed exceptions
and behaviour.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Oli Bartsch +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 7

Review log 1764

Show 1139 earlier messages
  1. Christian Kuhn uploaded patch set 1 02/17/21, 21:44

  2. Christian Kuhn marked it work in progress 02/17/21, 21:49

  3. TYPO3com voted on patch set 1 V -1 02/17/21, 21:54 Completed build in 09m 29s on Wed, 17 Feb, 09:54 PM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9604

  4. core-ci voted on patch set 1 V -1 02/17/21, 21:55 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/819

  5. Christian Kuhn uploaded patch set 2 02/17/21, 22:33

  6. TYPO3com voted on patch set 2 V -1 02/17/21, 22:41 Completed build in 08m 09s on Wed, 17 Feb, 10:41 PM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9605

  7. core-ci voted on patch set 2 V -1 02/17/21, 22:45 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/820

  8. Christian Kuhn uploaded patch set 3 02/23/21, 13:55

  9. Christian Kuhn rebased onto patch set 4 02/23/21, 14:01

  10. TYPO3com voted on patch set 4 V -1 02/23/21, 14:01 Completed build in 23s on Tue, 23 Feb, 02:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9680

  11. core-ci voted on patch set 4 V -1 02/23/21, 14:02 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/916

  12. Christian Kuhn uploaded patch set 5 02/23/21, 14:04

  13. TYPO3com voted on patch set 5 V -1 02/23/21, 14:10 Completed build in 06m 19s on Tue, 23 Feb, 02:10 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9681

  14. core-ci voted on patch set 5 V +1 02/23/21, 14:14 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/917

  15. TYPO3com voted on patch set 5 V +1 02/23/21, 14:17 Completed build in 18m 58s on Tue, 23 Feb, 02:17 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9681

  16. Christian Kuhn uploaded patch set 6 02/23/21, 16:16

  17. Christian Kuhn marked it ready for review 02/23/21, 16:18

  18. TYPO3com voted on patch set 6 V +1 02/23/21, 16:23 Completed build in 07m 06s on Tue, 23 Feb, 04:23 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9682

  19. core-ci voted on patch set 6 V +1 02/23/21, 16:30 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/920

  20. core-ci commented on patch set 6 02/23/21, 16:58 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/925

  21. core-ci voted on patch set 6 V -1 02/23/21, 16:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/922

  22. core-ci commented on patch set 6 02/23/21, 17:00 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/921

  23. core-ci commented on patch set 6 02/23/21, 17:00 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/926

  24. core-ci commented on patch set 6 02/23/21, 17:01 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/923

  25. core-ci voted on patch set 6 V +1 02/23/21, 17:02 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/924

  26. core-ci commented on patch set 6 02/23/21, 17:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/927

  27. core-ci commented on patch set 6 02/23/21, 17:09 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/929

  28. core-ci commented on patch set 6 02/23/21, 17:10 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/930

  29. core-ci voted on patch set 6 V -1 02/23/21, 17:10 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/928

  30. core-ci commented on patch set 6 02/23/21, 17:12 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/931

  31. Christian Kuhn commented on patch set 6 CR -1 02/23/21, 17:53

    one scheduler related test is flaky - sometimes a tooltip overlays buttons ... tooltips in BE are currently a bit funny anyways, will dig deeper.
  32. Christian Kuhn rebased onto patch set 7 02/24/21, 12:38

  33. TYPO3com voted on patch set 7 V +1 02/24/21, 12:47 Completed build in 08m 30s on Wed, 24 Feb, 12:47 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9694

  34. core-ci voted on patch set 7 V -1 02/24/21, 12:52 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/946

  35. Christian Kuhn uploaded patch set 8 02/24/21, 13:22

  36. TYPO3com voted on patch set 8 V +1 02/24/21, 13:31 Completed build in 09m 41s on Wed, 24 Feb, 01:31 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9696

  37. core-ci voted on patch set 8 V +1 02/24/21, 13:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/948

  38. core-ci voted on patch set 8 V -1 02/24/21, 13:49 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/950

  39. core-ci commented on patch set 8 02/24/21, 13:50 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/949

  1. Christian Kuhn uploaded patch set 9 02/24/21, 13:51

  2. TYPO3com voted on patch set 9 V +1 02/24/21, 13:58 Completed build in 06m 30s on Wed, 24 Feb, 01:58 PM Test Summary: 32686 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9699

  3. core-ci commented on patch set 8 02/24/21, 13:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/952

  4. core-ci commented on patch set 8 02/24/21, 13:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/955

  5. core-ci commented on patch set 8 02/24/21, 13:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/954

  6. core-ci commented on patch set 8 02/24/21, 13:59 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/953

  7. core-ci commented on patch set 8 02/24/21, 14:00 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/951

  8. core-ci voted on patch set 8 V +1 02/24/21, 14:00 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/956

  9. core-ci voted on patch set 8 V -1 02/24/21, 14:04 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/957

  10. core-ci voted on patch set 9 V +1 02/24/21, 14:08 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/960

  11. core-ci commented on patch set 9 02/24/21, 14:17 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/961

  12. core-ci commented on patch set 9 02/24/21, 14:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/964

  13. core-ci commented on patch set 9 02/24/21, 14:20 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/962

  14. core-ci commented on patch set 9 02/24/21, 14:23 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/963

  15. core-ci commented on patch set 9 02/24/21, 14:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/965

  16. core-ci commented on patch set 9 02/24/21, 14:27 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/966

  17. core-ci commented on patch set 9 02/24/21, 14:28 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/967

  18. core-ci commented on patch set 9 02/24/21, 14:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/968

  19. core-ci commented on patch set 9 02/24/21, 14:31 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/970

  20. core-ci commented on patch set 9 02/24/21, 14:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/969

  21. Oli Bartsch voted on patch set 9 V +1 CR +1 02/24/21, 14:53

  22. Richard Haeser voted on patch set 9 V +2 CR +2 02/24/21, 15:36

  23. Richard Haeser merged patch set 10 02/24/21, 15:36

  24. Benjamin Franzke commented on patch set 10 02/25/21, 13:33

    docker-compose.yml:4

    I've got a quick question: Why is this changed for local/gitlab testing only, and not (yet) for bamboo? Is there a blocker, or could this also be applied to the bamboo docker-compose?
  25. Christian Kuhn commented on patch set 10 02/25/21, 14:21

    docker-compose.yml:4 Reply Unresolved

    bamboo will phase out "soon", so i did not went through the trouble of taking care of bamboo here.