67967[TASK] Hide language flag and label when only one language is configured
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 46
-
Eric Chavaillaz uploaded patch set 1 02/19/21, 14:25
-
Xavier Perseguers commented on patch set 1 02/19/21, 14:29
PageLayoutView.php:1139Unresolvedsame here and since checking $langMode "costs" less than counting elements, I'd suggest to keep $langMode at the beginning -
TYPO3com voted on patch set 1 V +1 02/19/21, 14:34 Completed build in 08m 46s on Fri, 19 Feb, 02:34 PM Test Summary: 32623 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9634
-
Oli Bartsch commented on patch set 1 CR -1 02/19/21, 14:34
There is already a pending patch in which a more generic solution is discussed https://review.typo3.org/c/Packages/TYPO3.CMS/+/67361. In short: Such behaviour is not limited to page module but applies to various parts and modules in the backend. Therefore a new context object should be introduced which should then be used for these checks. This will in the end - hopefully - lead to an unified logic through the whole backend. -
core-ci voted on patch set 1 V +1 02/19/21, 14:35 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/855
-
Eric Chavaillaz abandoned the change 03/31/21, 13:38
GridColumnItem.php:170Unresolved