Review main Abandoned

67971[BUGFIX] Suppress Undefined index 'allowedSubProperties' notice

Jochen Roth CR 0 V 0 Easy +6 −4 updated 02/22/21, 08:49

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 511

  1. Jochen Roth uploaded patch set 1 02/19/21, 16:58

  2. TYPO3com voted on patch set 1 V -1 02/19/21, 17:06 Completed build in 08m 15s on Fri, 19 Feb, 05:06 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9640

  3. core-ci voted on patch set 1 V -1 02/19/21, 17:10 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/860

  4. Jochen Roth uploaded patch set 2 02/22/21, 08:17

  5. Jochen Roth uploaded patch set 3 02/22/21, 08:18

  6. TYPO3com commented on patch set 2 02/22/21, 08:24 Completed build in 06m 38s on Mon, 22 Feb, 08:24 AM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9650

  7. core-ci commented on patch set 2 02/22/21, 08:29 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/879

  8. TYPO3com voted on patch set 3 V +1 02/22/21, 08:29 Completed build in 11m 05s on Mon, 22 Feb, 08:29 AM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9651

  9. Oli Bartsch commented on patch set 3 02/22/21, 08:32

    AbstractMetaTagManager.php:298 Unresolved

    Why does `$handledPropertyConfig['allowedSubProperties'] ?? []` not already "catch" the undefined index notice?
  10. core-ci voted on patch set 3 V -1 02/22/21, 08:33 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/880

  11. Jochen Roth abandoned the change 02/22/21, 08:49

    Not an issue in most recent master