Review main Merged

67973[BUGFIX] Fix styling in AdminPanel

Kevin Appelt CR +2 V +2 Easy +1 −3 updated 02/22/21, 12:18

Commit message

Since Bootstrap 5, the legacy.scss is also included
in the Admin Panel, which breaks the layout.

The change removes the legacy.scss and mixins inclusion,
and makes the Admin Panel work again.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Kevin Appelt +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benni Mack +2
    • Kevin Appelt +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 2

Review log 919

  1. Kevin Appelt uploaded patch set 1 02/21/21, 10:39

  2. TYPO3com voted on patch set 1 V +1 02/21/21, 10:48 Completed build in 08m 17s on Sun, 21 Feb, 10:48 AM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9646

  3. core-ci voted on patch set 1 V +1 02/21/21, 10:52 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/872

  4. Martin Kutschker commented on patch set 1 02/21/21, 17:19

    adminpanel.scss:12 Unresolved

    The cropper mixins aren't used.

    adminpanel.scss:126 Unresolved

    None of the legacy rules or mixins are used.
  5. Martin Kutschker uploaded patch set 2 02/21/21, 17:22

  6. TYPO3com voted on patch set 2 V +1 02/21/21, 17:30 Completed build in 08m 32s on Sun, 21 Feb, 05:30 PM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9648

  7. core-ci voted on patch set 2 V +1 02/21/21, 17:32 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/874

  8. Benni Mack updated the commit message in patch set 3 02/22/21, 08:59

  9. TYPO3com voted on patch set 3 V +1 02/22/21, 09:06 Completed build in 06m 31s on Mon, 22 Feb, 09:06 AM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9652

  10. core-ci voted on patch set 3 V -1 02/22/21, 09:11 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/881

  11. Benni Mack updated the commit message in patch set 4 02/22/21, 09:17

  12. TYPO3com voted on patch set 4 V +1 02/22/21, 09:23 Completed build in 06m 24s on Mon, 22 Feb, 09:23 AM Test Summary: 32684 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9653

  13. core-ci voted on patch set 4 V -1 02/22/21, 09:27 Core CI is not happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/882

  14. core-ci voted on patch set 3 V +1 02/22/21, 09:46 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/881

  15. core-ci voted on patch set 4 V +1 02/22/21, 10:26 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/882

  16. Kevin Appelt commented on patch set 4 V +1 CR +1 02/22/21, 10:36

    My problem is solved with this and as far as I can see the AdminPanel is not broken.
  17. Benni Mack voted on patch set 4 V +2 CR +2 02/22/21, 10:46

  18. Benni Mack merged patch set 5 02/22/21, 10:46

  19. Oliver Hader voted on patch set 5 CR +1 02/22/21, 12:18